Performance degradation when using StringInputStream for stdin input

[DartBot]

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

1. Run the attached program with the given stdin input file.
2. At the end of the program remove the comment from one method and comment the other method to compare them:

main() {
  readLines();
// readRawLines();
  exit(0);
}

1. Run the program like this:

$ time dart_release wrangler.dart < mega_sample.txt > /dev/null

What is the expected output? What do you see instead?

Something closer to these times:

readRawLines Line count: 2000, Content length: 336900

real 0m0.126s
user 0m0.104s
sys 0m0.020s

But getting this instead:

readLines Line count: 2000, Content length: 336900

real 0m1.327s
user 0m1.280s
sys 0m0.044s

What version of the product are you using? On what operating system?

Bleeding-edge Dart. Linux manga 3.0.0-13-generic-pae #­22-Ubuntu SMP Wed Nov 2 15:17:35 UTC 2011 i686 i686 i386 GNU/Linux

Please provide any additional information below.

The program and sample file follow in attaches.

---

Attachments:
wrangler.dart (1.27 KB)
mega_sample.txt (330.96 KB)

[DartBot]

This comment was originally written by @jpedrosa

---

After applying the patch for issue #555 things look prettier:

https://code.google.com/p/dart/issues/detail?id=555&sort=-id&colspec=ID%20Type%20Status%20Priority%20Area%20Owner%20Summary

$ time dart_release wrangler.dart < mega_sample.txt > /dev/null
readLines Line count: 2000, Content length: 336900

real 0m0.439s
user 0m0.420s
sys 0m0.020s

I think we can close this issue for now.

Cheers.

[whesse]

Fixed by commit r1777, but note bug 571 : http://code.google.com/p/dart/issues/detail?id=571
FileInputStream and stdin do not work correctly with StringInputStream at the present time. The read handler and close handler of StringInputStream will not be called.

---

Set owner to @whesse.
Added Area-Library, Fixed labels.