-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element.html("foo") is not catchable inside try/catch #1014
Comments
This comment was originally written by [email protected] At the moment in order to catch all exceptions you need to do: |
nweiz fixed this yesterday as part of a slightly related SVG CL Added Fixed label. |
dart-bot
pushed a commit
that referenced
this issue
Mar 18, 2021
2021-03-18 [email protected] Fixes Issue #1020: SharedOptions comment corrected. 2021-03-18 [email protected] Fixes #1014. Expect compile error on dart2js for big integers Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I6ca1c23cbc3e2f7ed87efb8062c19d1b0c819bd8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191880 Auto-Submit: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]> Commit-Queue: William Hesse <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 1, 2023
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/b65622a..75efa6c): 75efa6c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#250) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf): f950bbf 2023-08-31 Parker Lougheed Regenerate worker protocol protos to add constructors and comments (#78) 9b4c6a0 2023-08-30 Parker Lougheed Update e2e_test dependencies (#79) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921): f255921 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#50) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393): 1f69393 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#48) cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3): 44118e3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#88) clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08): 1e75f08 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f): c058c8f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#86) crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879): 1e26879 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#151) csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a): bd30a1a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#188) dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218): 695b218c 2023-08-30 Sam Rawlins Tidy Category: (#3488) b26af96f 2023-08-30 Sam Rawlins Tidy up library exports (#3487) be35cb00 2023-08-29 Devon Carew Update dependabot.yaml (#3486) 649bb8d2 2023-08-29 Sam Rawlins Migrate to create_api_docs.dart (#3482) ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de): 89e58de 2023-09-01 Hossein Yousefi also install flutter on validate (#160) f95d0f2 2023-09-01 Hossein Yousefi Add use-flutter arg to validate (#159) 8743a9d 2023-09-01 Moritz Pass a parameter for Flutter `firehose` support (#158) 54d1628 2023-08-31 Moritz Setup Flutter in publish workflow (#157) 8fa89c6 2023-08-31 Moritz Add flutter support (#155) 65817bf 2023-08-29 Moritz Switch to Pub API (#152) ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a): d36e05a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#208) fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065): 87ed065 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#114) http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6): 7fb6fd6 2023-08-31 Brian Quinlan Clarify how to set the body without a content type header (#1014) lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3): da44af3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#144) logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f): bcaad0f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#147) markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1): 6cfd6f1 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#554) 52be591 2023-08-30 Parker Lougheed Fix a few more lints, no longer ignore line length (#552) matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6): 80910d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#227) mime (https://github.com/dart-lang/mime/compare/799b398..37ef637): 37ef637 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#104) native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc): a2dfedc 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#117) 8dfb0d2 2023-09-01 dependabot[bot] Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118) path (https://github.com/dart-lang/path/compare/7c2324b..96d9183): 96d9183 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35): a5bee35 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#73) shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76): 2926f76 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#376) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf): 196d7bf 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588): eeb2588 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#87) 2bb1a6e 2023-09-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88) stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b): bcf2a0b 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#140) stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6): 0ce7ab6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#94) string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c): da9142c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#62) term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285): 1b28285 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1): 27dcae11 2023-09-01 dependabot[bot] Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086) cf0a0a73 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#2085) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d): 030193d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23): 2a6ee23 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#47) tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6): 2c8cbd6 2023-09-01 Jonas Finnemann Jensen Extension discovery 2.0.0 (#156) 3e12c2e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#157) 0f28f80 2023-08-28 Kenzie Davisson Prepare extension_discovery for 1.0.1 release (#154) typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943): 80e8943 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#72) watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e): 1aed03e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#149) yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187): ae00187 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d): 4a9734d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#56) 83f9033 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by [email protected]
What steps will reproduce the problem?
try{
var test = new Element.html("foo");
}catch(Exception e){
//doesn't catch
}
What is the expected output? What do you see instead?
Throws a javascript exception that is not caught in the Dart exception.
The javascript exception is: 'Uncaught HTML had 0 top level elements but 1 expected'
What version of the product are you using? On what operating system?
minfrog
The text was updated successfully, but these errors were encountered: