-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'null' and 'false' to be the only falsey values #159
Labels
area-language
Dart language related items (some items might be better tracked at github.com/dart-lang/language).
closed-not-planned
Closed as we don't intend to take action on the reported issue
type-enhancement
A request for a change that isn't a bug
Comments
This comment was originally written by [email protected] Removed Type-Defect label. |
Added WontFix label. |
DartBot
added
Type-Enhancement
area-language
Dart language related items (some items might be better tracked at github.com/dart-lang/language).
labels
Apr 12, 2012
kevmoo
added
closed-not-planned
Closed as we don't intend to take action on the reported issue
type-enhancement
A request for a change that isn't a bug
and removed
resolution-wont_fix
labels
Mar 1, 2016
nex3
pushed a commit
that referenced
this issue
Aug 31, 2016
This was referenced Oct 29, 2020
dart-bot
pushed a commit
that referenced
this issue
Jan 7, 2021
Changes: 63f1110 Make argument to featureValueOf dynamic (#164) 71eeaee Make the item argument to Match dynamic again (#163) 2071cfd Add types to more parameters (#162) 5d52720 Allow null-safe code to do `same(null)`. (#161) 05db35c Delete .test_config (#160) e8b4964 remove redundant experiment (#159) 48fe280 Bump SDK constraints for pub (#158) 225cc13 allow the 2.12 prerelease sdks (#157) b9ce574 Prepare for the 2.11 dev SDKs (#156) fe4e68a Update .travis.yml Change-Id: I90c8d9d2f21d6454f1ace977deb9efec0d29d93d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177881 Reviewed-by: David Morgan <[email protected]> Commit-Queue: Ivan Inozemtsev <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Sep 14, 2021
Most of these are from a single PR that did not get squashed. Running `git log --format=%C(auto) %h %s e0780cd8b2f8af69a28dc52678ffe8492da27d06..016dd302b494e4ff70a7850957ec895eced9d220` in third_party/pkg/usage ✓ 016dd30 Prepare release (#160) 076c653 Merge pull request #152 from sigurdm/batching 1d6b343 Remove debug print c073fb7 Use correct limit for bytes 1d89875 Send batch early if full 2896a85 Update README.md da20fab Delete travis.sh 7c351a3 Merge 0424091 Update build.yaml (#159) 4f2a050 Use a Duration for batching delay aa3f3ce address review 318ebe5 Fix 71ddec1 Send remaining hits on waitForLastPing 1c895a7 Parametrize client-id in test 0ae7733 Fix pubspec 2255b3d Merge remote-tracking branch 'origin/master' into batching 14d3702 Merge remote-tracking branch 'origin/master' into batching 1c3393d Handle batching implicit waiting for a 'batchDelay' future 219b764 TODO about size of payloads aaee6d9 Fix AnalyticsMock a8ec5b4 Remove mockito as dep - didn't use it e26fcce Allow batching of hits Change-Id: I801c0d9114fb90e1dc94c3e2552c1cd90a8f0c18 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213349 Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Sep 15, 2021
This reverts commit b4c19b9. Reason for revert: http://b/199988795 Original change's description: > Bump package:usage. > > Most of these are from a single PR that did not get squashed. > > Running `git log --format=%C(auto) %h %s e0780cd8b2f8af69a28dc52678ffe8492da27d06..016dd302b494e4ff70a7850957ec895eced9d220` in third_party/pkg/usage ✓ > 016dd30 Prepare release (#160) > 076c653 Merge pull request #152 from sigurdm/batching > 1d6b343 Remove debug print > c073fb7 Use correct limit for bytes > 1d89875 Send batch early if full > 2896a85 Update README.md > da20fab Delete travis.sh > 7c351a3 Merge > 0424091 Update build.yaml (#159) > 4f2a050 Use a Duration for batching delay > aa3f3ce address review > 318ebe5 Fix > 71ddec1 Send remaining hits on waitForLastPing > 1c895a7 Parametrize client-id in test > 0ae7733 Fix pubspec > 2255b3d Merge remote-tracking branch 'origin/master' into batching > 14d3702 Merge remote-tracking branch 'origin/master' into batching > 1c3393d Handle batching implicit waiting for a 'batchDelay' future > 219b764 TODO about size of payloads > aaee6d9 Fix AnalyticsMock > a8ec5b4 Remove mockito as dep - didn't use it > e26fcce Allow batching of hits > > Change-Id: I801c0d9114fb90e1dc94c3e2552c1cd90a8f0c18 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213349 > Reviewed-by: Jonas Jensen <[email protected]> > Commit-Queue: Sigurd Meldgaard <[email protected]> [email protected],[email protected] Change-Id: I3b044a1744bbe5aade9c75fecb9d057d6564ddda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213440 Reviewed-by: Michal Terepeta <[email protected]> Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Michal Terepeta <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 12, 2021
This is a reland of: https://dart-review.googlesource.com/c/sdk/+/213349 Reverted in https://dart-review.googlesource.com/c/sdk/+/213440 due to http://b/199988795 The two failures in that issue has been addressed by "ac53249 Fix timeout" and "117d3a1 Allow sendRaw to send Map<String, dynamic>" Most of these commits stem from a non-squashed merge. Changes: ``` > git log --format="%C(auto) %h %s" e0780cd..ac53249 https://dart.googlesource.com/usage.git/+/ac53249 Fix timeout (#162) https://dart.googlesource.com/usage.git/+/117d3a1 Allow sendRaw to send Map<String, dynamic> (#161) https://dart.googlesource.com/usage.git/+/016dd30 Prepare release (#160) https://dart.googlesource.com/usage.git/+/076c653 Merge pull request #152 from sigurdm/batching https://dart.googlesource.com/usage.git/+/1d6b343 Remove debug print https://dart.googlesource.com/usage.git/+/c073fb7 Use correct limit for bytes https://dart.googlesource.com/usage.git/+/1d89875 Send batch early if full https://dart.googlesource.com/usage.git/+/2896a85 Update README.md https://dart.googlesource.com/usage.git/+/da20fab Delete travis.sh https://dart.googlesource.com/usage.git/+/7c351a3 Merge https://dart.googlesource.com/usage.git/+/0424091 Update build.yaml (#159) https://dart.googlesource.com/usage.git/+/4f2a050 Use a Duration for batching delay https://dart.googlesource.com/usage.git/+/aa3f3ce address review https://dart.googlesource.com/usage.git/+/318ebe5 Fix https://dart.googlesource.com/usage.git/+/71ddec1 Send remaining hits on waitForLastPing https://dart.googlesource.com/usage.git/+/1c895a7 Parametrize client-id in test https://dart.googlesource.com/usage.git/+/0ae7733 Fix pubspec https://dart.googlesource.com/usage.git/+/2255b3d Merge remote-tracking branch 'origin/master' into batching https://dart.googlesource.com/usage.git/+/14d3702 Merge remote-tracking branch 'origin/master' into batching https://dart.googlesource.com/usage.git/+/1c3393d Handle batching implicit waiting for a 'batchDelay' future https://dart.googlesource.com/usage.git/+/219b764 TODO about size of payloads https://dart.googlesource.com/usage.git/+/aaee6d9 Fix AnalyticsMock https://dart.googlesource.com/usage.git/+/a8ec5b4 Remove mockito as dep - didn't use it https://dart.googlesource.com/usage.git/+/e26fcce Allow batching of hits ``` Diff: https://dart.googlesource.com/usage.git/+/e0780cd8b2f8af69a28dc52678ffe8492da27d06~..ac53249e5230a77624f46c07c2ed965efcfc0c59/ Change-Id: I1284db2a23a3e9ac037d1d2a80627c0caa1e9385 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216184 Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 14, 2021
This reverts commit b2ea872. Reason for revert: Broke //third_party/fuchsia_gui_tools/fuchsia_devtools:tests_test_fuchsia_devtools_app_test.host Original change's description: > Bump usage to ac53249e5230a77624f46c07c2ed965efcfc0c59 > > This is a reland of: https://dart-review.googlesource.com/c/sdk/+/213349 > Reverted in https://dart-review.googlesource.com/c/sdk/+/213440 due to http://b/199988795 > > The two failures in that issue has been addressed by "ac53249 Fix timeout" and "117d3a1 Allow sendRaw to send Map<String, dynamic>" > > > Most of these commits stem from a non-squashed merge. > > Changes: > ``` > > git log --format="%C(auto) %h %s" e0780cd..ac53249 > https://dart.googlesource.com/usage.git/+/ac53249 Fix timeout (#162) > https://dart.googlesource.com/usage.git/+/117d3a1 Allow sendRaw to send Map<String, dynamic> (#161) > https://dart.googlesource.com/usage.git/+/016dd30 Prepare release (#160) > https://dart.googlesource.com/usage.git/+/076c653 Merge pull request #152 from sigurdm/batching > https://dart.googlesource.com/usage.git/+/1d6b343 Remove debug print > https://dart.googlesource.com/usage.git/+/c073fb7 Use correct limit for bytes > https://dart.googlesource.com/usage.git/+/1d89875 Send batch early if full > https://dart.googlesource.com/usage.git/+/2896a85 Update README.md > https://dart.googlesource.com/usage.git/+/da20fab Delete travis.sh > https://dart.googlesource.com/usage.git/+/7c351a3 Merge > https://dart.googlesource.com/usage.git/+/0424091 Update build.yaml (#159) > https://dart.googlesource.com/usage.git/+/4f2a050 Use a Duration for batching delay > https://dart.googlesource.com/usage.git/+/aa3f3ce address review > https://dart.googlesource.com/usage.git/+/318ebe5 Fix > https://dart.googlesource.com/usage.git/+/71ddec1 Send remaining hits on waitForLastPing > https://dart.googlesource.com/usage.git/+/1c895a7 Parametrize client-id in test > https://dart.googlesource.com/usage.git/+/0ae7733 Fix pubspec > https://dart.googlesource.com/usage.git/+/2255b3d Merge remote-tracking branch 'origin/master' into batching > https://dart.googlesource.com/usage.git/+/14d3702 Merge remote-tracking branch 'origin/master' into batching > https://dart.googlesource.com/usage.git/+/1c3393d Handle batching implicit waiting for a 'batchDelay' future > https://dart.googlesource.com/usage.git/+/219b764 TODO about size of payloads > https://dart.googlesource.com/usage.git/+/aaee6d9 Fix AnalyticsMock > https://dart.googlesource.com/usage.git/+/a8ec5b4 Remove mockito as dep - didn't use it > https://dart.googlesource.com/usage.git/+/e26fcce Allow batching of hits > > ``` > > Diff: https://dart.googlesource.com/usage.git/+/e0780cd8b2f8af69a28dc52678ffe8492da27d06~..ac53249e5230a77624f46c07c2ed965efcfc0c59/ > Change-Id: I1284db2a23a3e9ac037d1d2a80627c0caa1e9385 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216184 > Reviewed-by: Jonas Jensen <[email protected]> > Commit-Queue: Sigurd Meldgaard <[email protected]> # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib58c23769f263435237881e6a57a4cab18bc2850 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216780 Reviewed-by: Sigurd Meldgaard <[email protected]> Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 14, 2021
This is a reland of https://dart-review.googlesource.com/c/sdk/+/216184 that was reverted due to b/203034967 The new commit f0cb8f7 `Don't batch per default` works around the issue (manually tested internally). Changes: ``` > git log --format="%C(auto) %h %s" e0780cd..f0cb8f7 https://dart.googlesource.com/usage.git/+/f0cb8f7 Don't batch per default (#164) https://dart.googlesource.com/usage.git/+/ac53249 Fix timeout (#162) https://dart.googlesource.com/usage.git/+/117d3a1 Allow sendRaw to send Map<String, dynamic> (#161) https://dart.googlesource.com/usage.git/+/016dd30 Prepare release (#160) https://dart.googlesource.com/usage.git/+/076c653 Merge pull request #152 from sigurdm/batching https://dart.googlesource.com/usage.git/+/1d6b343 Remove debug print https://dart.googlesource.com/usage.git/+/c073fb7 Use correct limit for bytes https://dart.googlesource.com/usage.git/+/1d89875 Send batch early if full https://dart.googlesource.com/usage.git/+/2896a85 Update README.md https://dart.googlesource.com/usage.git/+/da20fab Delete travis.sh https://dart.googlesource.com/usage.git/+/7c351a3 Merge https://dart.googlesource.com/usage.git/+/0424091 Update build.yaml (#159) https://dart.googlesource.com/usage.git/+/4f2a050 Use a Duration for batching delay https://dart.googlesource.com/usage.git/+/aa3f3ce address review https://dart.googlesource.com/usage.git/+/318ebe5 Fix https://dart.googlesource.com/usage.git/+/71ddec1 Send remaining hits on waitForLastPing https://dart.googlesource.com/usage.git/+/1c895a7 Parametrize client-id in test https://dart.googlesource.com/usage.git/+/0ae7733 Fix pubspec https://dart.googlesource.com/usage.git/+/2255b3d Merge remote-tracking branch 'origin/master' into batching https://dart.googlesource.com/usage.git/+/14d3702 Merge remote-tracking branch 'origin/master' into batching https://dart.googlesource.com/usage.git/+/1c3393d Handle batching implicit waiting for a 'batchDelay' future https://dart.googlesource.com/usage.git/+/219b764 TODO about size of payloads https://dart.googlesource.com/usage.git/+/aaee6d9 Fix AnalyticsMock https://dart.googlesource.com/usage.git/+/a8ec5b4 Remove mockito as dep - didn't use it https://dart.googlesource.com/usage.git/+/e26fcce Allow batching of hits ``` Diff: https://dart.googlesource.com/usage.git/+/e0780cd8b2f8af69a28dc52678ffe8492da27d06~..f0cb8f7cce8b675255c81488dbab8cf9f2f56404/ Change-Id: Iccac84c5182953209d7c05ac47cbde82e59a590d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216803 Commit-Queue: Sigurd Meldgaard <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 1, 2023
…li_util, clock, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, http, lints, logging, markdown, matcher, mime, native, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, tools, typed_data, watcher, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/b65622a..75efa6c): 75efa6c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#250) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c29d162..f950bbf): f950bbf 2023-08-31 Parker Lougheed Regenerate worker protocol protos to add constructors and comments (#78) 9b4c6a0 2023-08-30 Parker Lougheed Update e2e_test dependencies (#79) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/303635d..f255921): f255921 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#50) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/27ec600..1f69393): 1f69393 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#48) cli_util (https://github.com/dart-lang/cli_util/compare/9b7ce78..44118e3): 44118e3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#88) clock (https://github.com/dart-lang/clock/compare/263e508..1e75f08): 1e75f08 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) convert (https://github.com/dart-lang/convert/compare/79ee174..c058c8f): c058c8f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#86) crypto (https://github.com/dart-lang/crypto/compare/8b704c6..1e26879): 1e26879 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#151) csslib (https://github.com/dart-lang/csslib/compare/7e91228..bd30a1a): bd30a1a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#188) dartdoc (https://github.com/dart-lang/dartdoc/compare/5fda5eb..695b218): 695b218c 2023-08-30 Sam Rawlins Tidy Category: (#3488) b26af96f 2023-08-30 Sam Rawlins Tidy up library exports (#3487) be35cb00 2023-08-29 Devon Carew Update dependabot.yaml (#3486) 649bb8d2 2023-08-29 Sam Rawlins Migrate to create_api_docs.dart (#3482) ecosystem (https://github.com/dart-lang/ecosystem/compare/f777da7..89e58de): 89e58de 2023-09-01 Hossein Yousefi also install flutter on validate (#160) f95d0f2 2023-09-01 Hossein Yousefi Add use-flutter arg to validate (#159) 8743a9d 2023-09-01 Moritz Pass a parameter for Flutter `firehose` support (#158) 54d1628 2023-08-31 Moritz Setup Flutter in publish workflow (#157) 8fa89c6 2023-08-31 Moritz Add flutter support (#155) 65817bf 2023-08-29 Moritz Switch to Pub API (#152) ffi (https://github.com/dart-lang/ffi/compare/e2c01a9..d36e05a): d36e05a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#208) fixnum (https://github.com/dart-lang/fixnum/compare/00fa120..87ed065): 87ed065 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#114) http (https://github.com/dart-lang/http/compare/cad7d60..7fb6fd6): 7fb6fd6 2023-08-31 Brian Quinlan Clarify how to set the body without a content type header (#1014) lints (https://github.com/dart-lang/lints/compare/54cd7a0..da44af3): da44af3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#144) logging (https://github.com/dart-lang/logging/compare/5214987..bcaad0f): bcaad0f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#147) markdown (https://github.com/dart-lang/markdown/compare/56e75df..6cfd6f1): 6cfd6f1 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#554) 52be591 2023-08-30 Parker Lougheed Fix a few more lints, no longer ignore line length (#552) matcher (https://github.com/dart-lang/matcher/compare/ce8f409..80910d6): 80910d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#227) mime (https://github.com/dart-lang/mime/compare/799b398..37ef637): 37ef637 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#104) native (https://github.com/dart-lang/native/compare/5a1361b..a2dfedc): a2dfedc 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#117) 8dfb0d2 2023-09-01 dependabot[bot] Bump nttld/setup-ndk from 1.2.0 to 1.3.1 (#118) path (https://github.com/dart-lang/path/compare/7c2324b..96d9183): 96d9183 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) pool (https://github.com/dart-lang/pool/compare/7700102..a5bee35): a5bee35 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#73) shelf (https://github.com/dart-lang/shelf/compare/73edd2b..2926f76): 2926f76 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#376) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/16e54fd..196d7bf): 196d7bf 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) sse (https://github.com/dart-lang/sse/compare/8cc5b11..eeb2588): eeb2588 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#87) 2bb1a6e 2023-09-01 dependabot[bot] Bump nanasess/setup-chromedriver from 2.1.1 to 2.2.0 (#88) stack_trace (https://github.com/dart-lang/stack_trace/compare/4ddd86d..bcf2a0b): bcf2a0b 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#140) stream_channel (https://github.com/dart-lang/stream_channel/compare/e54234f..0ce7ab6): 0ce7ab6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#94) string_scanner (https://github.com/dart-lang/string_scanner/compare/413b57a..da9142c): da9142c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#62) term_glyph (https://github.com/dart-lang/term_glyph/compare/423700a..1b28285): 1b28285 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#41) test (https://github.com/dart-lang/test/compare/d0fc4bd..27dcae1): 27dcae11 2023-09-01 dependabot[bot] Bump github/codeql-action from 2.21.2 to 2.21.5 (#2086) cf0a0a73 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#2085) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/36d8617..030193d): 030193d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#55) test_process (https://github.com/dart-lang/test_process/compare/b360784..2a6ee23): 2a6ee23 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#47) tools (https://github.com/dart-lang/tools/compare/b72fae8..2c8cbd6): 2c8cbd6 2023-09-01 Jonas Finnemann Jensen Extension discovery 2.0.0 (#156) 3e12c2e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#157) 0f28f80 2023-08-28 Kenzie Davisson Prepare extension_discovery for 1.0.1 release (#154) typed_data (https://github.com/dart-lang/typed_data/compare/a20be90..80e8943): 80e8943 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#72) watcher (https://github.com/dart-lang/watcher/compare/7457413..1aed03e): 1aed03e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#149) yaml (https://github.com/dart-lang/yaml/compare/7930148..ae00187): ae00187 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#150) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/87dcf31..4a9734d): 4a9734d 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#56) 83f9033 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) Change-Id: Ie6b9d9ef138730b98e9df8cbb31c6cc330ada9f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323703 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-language
Dart language related items (some items might be better tracked at github.com/dart-lang/language).
closed-not-planned
Closed as we don't intend to take action on the reported issue
type-enhancement
A request for a change that isn't a bug
This issue was originally filed by [email protected]
I'd like to propose a change to Dart's boolean conversion. I think it is best if "false" and "null" convert to false, and everything else converts to true:
(bool v) {
return null != v && false !== v;
}(o)
Ruby and Scheme have this behavior. With the change, it is possible to check if a variable is null without including "!= null". Checking for null is common, and this change would get rid of some of verbosity of Java. Not only would this be shorter code, but it would be closer to how most other languages behave. In many languages (C, D, PHP, JavaScript, Python, Ruby, and others), code equivalent to the following works:
obj = getPerson();
if(obj) {
...
}
This wouldn't affect the "(a-b)" example in the language spec--it still wouldn't work. It would just be always true instead of always false.
I'm not sure I understand the boolean-being-autoboxed problem mentioned in the spec. I know "new Boolean(false)" is coerced to true in JavaScript, but when is a boolean autoboxed? I know it is if you call one of its methods, but how would you convert it back to a boolean then?
In any case, I don't see how the proposal would affect this. If Dart makes all objects convert to false to make "new Boolean(false)" be false, then wouldn't it also make "new Boolean(true)" be false?
The idea was mentioned on reddit and most people liked it:
http://www.reddit.com/r/programming/comments/l88ny/why_dart_is_not_the_language_of_the_future/c2qlzed
A couple of people didn't, but they weren't happy with the spec as it is either (they wanted 1 to be true and 0 to be false).
The text was updated successfully, but these errors were encountered: