Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries view should sort private types to the bottom of the list. #217

Closed
bwilkerson opened this issue Oct 24, 2011 · 3 comments
Closed

Libraries view should sort private types to the bottom of the list. #217

bwilkerson opened this issue Oct 24, 2011 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@bwilkerson
Copy link
Member

What steps will reproduce the problem?

  1. Create a new application (or open an existing library that imports dart:dom).
  2. Expand dart:dom.

What is the expected output? What do you see instead?

The leading underscore in private names appears to be ignored for purposes of sorting the content. Given that one of the most common use cases for expanding an imported library is to discover what functionality is available I think that private names should either be hidden or at least sorted to the bottom of the list.
@danrubel
Copy link

danrubel commented Nov 1, 2011

Removed Type-Defect label.
Added Type-Enhancement label.

@jwren
Copy link
Member

jwren commented Nov 1, 2011

They were being sorted to the bottom of the list until Devon, a few days before the initial binary release, changed it to the current behavior. (I don't know who motivated the change to the current behavior.)

I don't have a huge preference either way. Perhaps we should ask Luke.

cc @devoncarew.
cc @lukechurch.

@danrubel
Copy link

Added Fixed label.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
nex3 pushed a commit that referenced this issue Aug 31, 2016
fixes #217, Object members on extension types
b62fdb5 
[email protected]

Review URL: https://codereview.chromium.org/1173023004.
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
@KTOLE18 KTOLE18 mentioned this issue Aug 10, 2021
Closed
@Mufaddal1125 Mufaddal1125 mentioned this issue May 13, 2023
Closed
copybara-service bot pushed a commit that referenced this issue May 15, 2023
@devoncarew
[deps] rev args, async, bazel_worker, benchmark_harness, boolean_sele…
e3ba855 
…ctor, browser_launcher, file, mockito, tools, dartdoc

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5

args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
  f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)

async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
  d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
  d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
  e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0):
  23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
  40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)

file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db):
  f05f5db  2023-05-15  James D. Lin  Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217)
  f2f3076  2023-05-12  Ross Wang  MemoryFileSystem addStream onError (#220)
  5e76f74  2023-05-12  James D. Lin  Fix MemoryFileSystem to treat an empty path as non-existent (#213)
  7941466  2023-05-12  James D. Lin  Make `FileSystem.isLink` actually work (#214)

mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571):
  b14d571  2023-05-15  Googler  Fix for InvalidType

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 16, 2023
Revert "[deps] rev args, async, bazel_worker, benchmark_harness, bool…
126a941 
…ean_selector, browser_launcher, file, mockito, tools, dartdoc"

This reverts commit e3ba855.

Reason for revert: b/282823291, breaks Flutter tests at least on Android.

Original change's description:
> [deps] rev args, async, bazel_worker, benchmark_harness, boolean_selector, browser_launcher, file, mockito, tools, dartdoc
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5
>
> args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
>   f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)
>
> async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
>   d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)
>
> bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
>   d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)
>
> benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
>   e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)
>
> boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0):
>   23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)
>
> browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
>   40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)
>
> file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db):
>   f05f5db  2023-05-15  James D. Lin  Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217)
>   f2f3076  2023-05-12  Ross Wang  MemoryFileSystem addStream onError (#220)
>   5e76f74  2023-05-12  James D. Lin  Fix MemoryFileSystem to treat an empty path as non-existent (#213)
>   7941466  2023-05-12  James D. Lin  Make `FileSystem.isLink` actually work (#214)
>
> mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571):
>   b14d571  2023-05-15  Googler  Fix for InvalidType
>
> tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
>   49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)
>
> Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380
> Reviewed-by: Konstantin Shcheglov <[email protected]>
> Commit-Queue: Devon Carew <[email protected]>

Change-Id: Ifc2aa278a47a4060f2be28c1950084eb0c2de812
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303720
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ilya Yanok <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jan 2, 2024
@devoncarew
[deps] crypto, logging, mime, path, pool, shelf, stask_trace, tools, …
334ac53 
…watcher, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

crypto (https://github.com/dart-lang/crypto/compare/63e9a90..f2efb98):
  f2efb98  2024-01-02  Kevin Moore  Require Dart 3.2, update and fix lints (#158)

logging (https://github.com/dart-lang/logging/compare/324a0b5..4d35a4e):
  4d35a4e  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#152)

mime (https://github.com/dart-lang/mime/compare/56359b0..ca9f059):
  ca9f059  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#111)

path (https://github.com/dart-lang/path/compare/115ea2a..57a049c):
  57a049c  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#157)
  5b6aac7  2023-12-20  Kevin Moore  blast_repo fixes (#156)

pool (https://github.com/dart-lang/pool/compare/3c1bd42..4c49000):
  4c49000  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#79)
  7e03d80  2023-12-20  Kevin Moore  blast_repo fixes (#78)

shelf (https://github.com/dart-lang/shelf/compare/b3adc7c..733588f):
  733588f  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#401)
  1eab426  2024-01-01  dependabot[bot]  Bump actions/labeler from 4.3.0 to 5.0.0 (#402)
  10cbffe  2023-12-14  Kevin Moore  Run web tests with wasm with dev Dart sdk (#398)

stack_trace (https://github.com/dart-lang/stack_trace/compare/4abff44..0f4710c):
  0f4710c  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#148)

tools (https://github.com/dart-lang/tools/compare/ed81684..2f59ab4):
  2f59ab4  2024-01-02  Daco Harkes  [graphs] Clean up lints for Dart 3.3 (#221)
  01fa883  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#223)
  9d4fe2f  2024-01-01  dependabot[bot]  Bump actions/labeler from 4.3.0 to 5.0.0 (#222)
  6d260b8  2023-12-14  Elias Yishak  Update USAGE_GUIDE to update the `flutterChannelCount` key in `LogFileStats` (#219)
  56a30ce  2023-12-11  Elias Yishak  Add `enabledFeatures` key to `Analytics` constructors (#217)

watcher (https://github.com/dart-lang/watcher/compare/dc45f19..66cd694):
  66cd694  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#161)
  679d308  2023-12-20  Kevin Moore  blast_repo fixes (#160)

yaml (https://github.com/dart-lang/yaml/compare/98a3aab..509fd72):
  509fd72  2023-12-11  Kevin Moore  update lints, require Dart 3.0 (#156)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/9b9d33c..47eb20e):
  47eb20e  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#63)
  a39ec39  2023-12-20  Kevin Moore  blast_repo fixes (#62)

Change-Id: I8009f4957a0eb751f36c2ec1be8aacbfc44ca586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344400
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @jwren @danrubel @bwilkerson