Typechecking of map literals does not always work in checked mode

[DartBot]

This issue was originally filed by [email protected]

---

If we provide type information when instantiating a new Map, we get runtime type-checking (VM, checked mode):
  var m1 = new Map<String, int>();
  m1["str"] = "hello"; // error: type OneByteString is not assignable to type int
  m1[1] = 2; // error: type Smi is not assignable to type String

I can't get the same behavior if I use Map literals, neither in the literal initializer nor in subsequent []= operations. No exception gets thrown for these two lines:
  var m2 = <String, String>{"a": 0}; // Map literal doesn't type-check values
  m2[2] = 1; // nor does []= (for keys or values)

I understand that Dart restricts Map literal keys to Strings and that those are already checked ("map entry key must be string literal").

[DartBot]

This comment was originally written by [email protected]

---

Removed Type-Defect label.
Added Type-Enhancement, Area-Language, Triaged labels.

[DartBot]

This comment was originally written by [email protected]

---

Isn't this a type-checking bug (i.e. a type-defect)?

[DartBot]

This comment was originally written by [email protected]

---

I guess my choice of title was slightly misleading. A better one would be "Type-checker ignores type-annotated Map literals".

[gbracha]

Looks like a bug to me.

---

Set owner to @crelier.
Removed Area-Language label.
Added Area-VM, Accepted labels.
Changed the title to: "Typechecking of map literals does not always work in checked mode".

[crelier]

Fixed in the VM in r1764.

[crelier]

Still needs fixing in dartc and frog.

---

Removed the owner.
Removed Area-VM label.
Added Area-Compiler, Triaged labels.

[sigmundch]

Fixed for frog in r2187

[DartBot]

This comment was originally written by [email protected]

---

Specifically, what needs to be done is dartc is to put run-time type checks into the array/map initializers. The checks on assignment (l[1] = 2) are working.

[DartBot]

This comment was originally written by [email protected]

---

Fixed in dartc r3619. Closing.

---

Added Fixed label.

[lrhn]

Closed incorrect issue, this one is still open.

[a-siva]

Why has this been reopened and assigned 'area-vm'? according to the comments this bug was fixed in the VM on Nov 22, 2011.

[lrhn]

Whoops. I was reopening bugs accidentally closed by the dev-compiler merge, and one of their commits seemd to close #270 and #221 - I didn't notice that 221 was already closed. My mistake.