invalid co19 test - need to change or remove co19 test

[DartBot]

This issue was originally filed by [email protected]

---

LangGuideTest/02_Language_Constructs/02_1_Class/02_1_Class_Construction/A02/t01

* @­description Checks return type corresponding to the class for named constructor.

class C {
  C C.makeC() { return this;}
}

main() {
  var c = new C.makeC();
}

generative constructors cannot have return type. the test purpose is not clear. it seems that indicate that constructors cannot have return type and at the same time checks for return type as per the description.

[DartBot]

This comment was originally written by [email protected]

---

This test is marked as @­compile-error, so this code is expected to be rejected.

Description is probably misleading, it means "Checks that generative constructor of class C can not specify C as a return type".

[DartBot]

This comment was originally written by [email protected]

---

I imagine it cant specify "C" or any other type. in other words, it cant specify any return type.

[DartBot]

This comment was originally written by [email protected]

---

Sure, that is what is written under @­assertion tag. The test performs a single check and this is documented in the description.

More checks will be provided in language spec test suite. LangGuideTests are just samples.

[DartBot]

This comment was originally written by [email protected]

---

just to be clear. what you mentioned before "Checks that generative constructor of class C can not specify C as a return type" and "generative constructors cannot have return types" are quite different things. neither the current description nor the assert makes this clear. moreover, if the test was only testing the existence of return type, it would not need a return statement in the constructor body.

I will change the test to the expected behavior.

[DartBot]

This comment was originally written by [email protected]

---

Set owner to [email protected].
Added Triaged label.

[DartBot]

This comment was originally written by [email protected]

---

Set owner to @peter-ahe-google.

[peter-ahe-google]

@fabio: Please let Unipro take care of changes to co19 tests. They have a process :-)

@ivan: I'm not sure this test is sufficiently testing the assertion. Please take a look at the test. It contains two errors:

1. A return statement in a constructor.
2. A return type annotation on a constructor.

[DartBot]

This comment was originally written by [email protected]

---

Let me make myself clear.

The assertion I took from the language guide says "A non-factory constructor doesn't have any return type (even in typed mode)"

So the test tries to specify return type annotation on a constructor and awaits a compile-error.

I see that return statement should be removed and description should probably be corrected. Could you guys please give me ideas for what else should be done?

[peter-ahe-google]

If you remove the return statement, we can close this bug.

[DartBot]

This comment was originally written by [email protected]

---

done at co19 r16

[peter-ahe-google]

Thank you!

---

Added Verified label.