Adding more than one Tesla mixes up attributes

[Jandaduns]

The problem

Using the front end Tesla integration feature, adding the first car goes fine, but adding a second car (with new credentials) only ‘finds’ the car that was added first - and then ‘steals’ all the attributes. This means under car 2 the attributes of car 1 are shown and car 1 does not have any attributes. I have previously added both cars without any issues, expect maybe 2021.1 was okay. In 2021.2 this was the first time I noticed it to be broken

What is version of Home Assistant Core has the issue?

core-2021.3.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Tesla

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tesla/

Example YAML snippet

# Put your YAML below this line

Anything in the logs that might be useful for us?

# Put your logs below this line

Platform tesla does not generate unique IDs. ID tesla_model_3_XXXXXX_door_lock already exists - ignoring lock.riding_hood_door_lock
11:52:20 – Lock (ERROR) - message first occurred at 8:53:37 and shows up 8 times
Unexpected error fetching tesla data: '[->tesla VIN removed<-]'
11:51:09 – Tesla (ERROR) - message first occurred at 8:54:39 and shows up 178 times

Here’s the screen after adding car number 2: the mentioned car is actually car number one.

[probot-home-assistant]

Hey there @zabuldon, @alandtse, mind taking a look at this issue as its been labeled with an integration (tesla) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[alandtse]

Are you adding two accounts with the same vehicle? We generate the unique name based on the vin. Please add a debug log for teslajsonpy in your logger. You will need to scrub the logs before you post them. Please leave the last six digits of the vin or any numbers intact though.

If this just occurred, we haven't changed any code related to this.

[Jandaduns]

Two cars: one called Red Wolf, the other Riding Hood. When I look at the log, it only sees the first Tesla (Red Wolf) and never retrieves the credentials for the second Tesla (Riding Hood).
So:

1. I add car 'Red Wolf' with credentials ([email protected]) -> car is correctly retrieved and integration is created
2. I add car 'Riding Hood' with new credentials ([email protected]) -> integration is created for [email protected] but refers to 'Red Wolf' and has all the attributes of 'Red Wolf'. The car under credentials [email protected] does not have any attributes anymore.
   Same happens if I remove the integrations and first add the other car:
3. I add car 'Riding Hood' with credentials ([email protected]) -> car is correctly retrieved and integration is created
4. I add car 'Red Wolf' with new credentials ([email protected]) -> integration is created for [email protected] but refers to 'Riding Hood' and has all the attributes of 'Riding Hood'. The car under credentials [email protected] does not have any attributes anymore.

[oscfor]

Can't you just invite the second car to account number one? Then you get both car with just the same integration. This is how I have both my Teslas in HA (before the oauth change...)

[alandtse]

Ok, the issue is because we share a single websession with HA, we can't connect to two different accounts at once. As soon as the second account connects, it'll clobber the cookies for the first session and both accounts will be logged in to the same account duplicating the vehicles. So while each account think's it's logged in to separate accounts, it's pulling same vehicle into both accounts.

The workaround for now is to add two vehicles to the same account.

[Jandaduns]

Good suggestion, @oscfor ! Works like a charm.
@alandtse thank you for looking in on this and for your fast reponse! Maybe good to update the documentation on this integration to reflect the one account - multiple cars functionality. Suggested text to add:
This integration can only handle one account. If you want to handle more than one car from different accounts, use the additional driver access function in the Tesla portal to make the additional car available in the account you use in home-assistant.

[alandtse]

Glad you got the workaround to work. Could you please submit it? I'm working on the code to fix it so you won't need the workaround, so if you can help out on the documentation I'd appreciate it.

[Jandaduns]

@alandtse Sure, I’ve updated the documentation and created the pull request.

[alandtse]

Thanks! I also have a PR fix if you wanted to test that. Unfortunately it will create two copies of your second car but it will at least let us know if it works. It should go away one you remove the extra account.

[Jandaduns]

Sure, lemme know.