Raise Spotify exception if no active device found

[spacegaier]

Breaking change

Proposed change

Currently we "silently" fail in the sense we add a log entry, but the user does not currently understand why nothing is happening when clicking in the frontend on the play button in a Spotify media card, when no device is active.

Now we raise an exception which will result in a frontend toast.

I handled it now through the spotify_exception_handler which however also results in a callstack trace in the log (not really sure why). As a test I had the exception raising initially implemented directly in the media_play and play_media method, but that felt less clean from a coding perspective.

This is how it looks in the fronted => I would have loved to only have the actual user message ("No active playback device found") as that would be cleaner and clearer.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[frenck]

I handled it now through the spotify_exception_handler which however also results in a callstack trace in the log (not really sure why).

To handle availability, that was (until now) its solve purpose :)

[frenck]

Nice! Thanks, @spacegaier 👍