Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade numpy to 1.20.2 #48597

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Upgrade numpy to 1.20.2 #48597

merged 1 commit into from
Apr 1, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 1, 2021

Proposed change

Release notes: https://numpy.org/doc/stable/release/1.20.0-notes.html

I've went through our codebase for deprecations, none found. Hard to tell for all subdeps.

This PR fixes issue #48565

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck
Copy link
Member Author

frenck commented Apr 1, 2021

Converting to draft.

image

Numpy has already landed, probably that version is build because of another dep (maybe a custom integration?) anyways, give me more room to test before marking this ready for review.

@frenck
Copy link
Member Author

frenck commented Apr 1, 2021

Tested in my production instance by modifying the runtime container and triggering S6 into restarting the Home Assistant service. Using Home Assistant Core 2021.4.0b0, as was the issue reported with.

Before:

image

image

After:

image

No error like that to be found anymore.

Have downgraded again to verify error returns and upgraded once again to verify it did indeed was gone.

@frenck frenck marked this pull request as ready for review April 1, 2021 20:16
@balloob balloob merged commit 528095b into dev Apr 1, 2021
@balloob balloob deleted the frenck-2021-1023 branch April 1, 2021 20:32
balloob pushed a commit that referenced this pull request Apr 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Exception 2021.4.0b0
4 participants