Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sonos event asyncio #48618

Merged
merged 10 commits into from
Apr 4, 2021
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 2, 2021

Proposed change

Make sonos event asyncio

pysonos changelog: amelchio/pysonos@v0.0.40...v0.0.41

Verified the port skip logic still works by running two containers on the same system.

2021-04-03 21:57:35 WARNING (MainThread) [pysonos.events_asyncio] [Errno 98] Address in use
2021-04-03 21:57:35 WARNING (MainThread) [pysonos.events_asyncio] Trying next port (1401)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review April 3, 2021 22:13
@bdraco bdraco marked this pull request as draft April 3, 2021 22:18
@bdraco
Copy link
Member Author

bdraco commented Apr 3, 2021

Tests need to manually mock since sonos api requires us to return coros manually TypeError: object Mock can't be used in 'await' expression

@bdraco bdraco marked this pull request as ready for review April 3, 2021 23:20
@balloob balloob merged commit bc06100 into home-assistant:dev Apr 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonos is leaking memory over time
5 participants