Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve cast delaying startup when discovered devices are slow to setup #48755

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 7, 2021

Proposed change

Solve cast delaying startup when cast devices are discovered during Home Assistant's startup phase but then are slow to respond or don't respond at all

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration (cast) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery added this to the 2021.4.0 milestone Apr 7, 2021
@emontnemery emontnemery changed the title Solve cast delaying startup when devices are slow to setup Solve cast delaying startup when discovered devices are slow to setup Apr 7, 2021
@emontnemery emontnemery merged commit 5f8fcca into home-assistant:dev Apr 7, 2021
frenck pushed a commit that referenced this pull request Apr 7, 2021
…#48755)

* Solve cast delaying startup when devices are slow to setup

* Update homeassistant/components/cast/media_player.py

Co-authored-by: Erik Montnemery <[email protected]>

Co-authored-by: Erik Montnemery <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch_log_coro_exception delays startup wrap up
5 participants