Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modbus CONF_VERIFY_STATE to new switch config #48632

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

janiversen
Copy link
Member

@janiversen janiversen commented Apr 2, 2021

Breaking change

Proposed change

Missed CONF_VERIFY_STATE in new switch config, when
copying from old switch config.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Missed CONF_VERIFY_STATE in new switch config, when
copying from old switch config.
@probot-home-assistant
Copy link

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Add CONF_VERIFY_STATE to new switch config. Add modbus CONF_VERIFY_STATE to new switch config Apr 2, 2021
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Apr 2, 2021

Side note: Please remove the space in the checkbox markdown so it can render as proper checkboxes in the PR description. Also put the PR change description under the correct header in the PR description.

@janiversen
Copy link
Member Author

Done

@MartinHjelmare MartinHjelmare merged commit cee43b0 into home-assistant:dev Apr 3, 2021
@janiversen janiversen deleted the config_error_switch branch April 3, 2021 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants