-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asyncio locks to screenlogic api access points #48457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
CI failure is unrelated. I restarted it, but it should be good to merge reguardless
API fixes shared socket collision when commands are called by multiple threads.
This reverts commit 870f4bc.
Protects api shared socket collisions/destruction.
4a42d2e
to
e26e516
Compare
I rebased to I'll merge it as soon as it passes |
Thank you! |
Proposed change
Add asyncio locks to api access points to protect api's shared socket against collisions/destruction.
FIxes a possible
[Errno 9] Bad file descriptor
when multiple switches are listed in a single call to switch.toggle/turn_on/turn_offType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: