-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New integration for Kostal Plenticore solar inverters #43404
Conversation
this will not work for kostal piko covertors, right? |
@pergolafabio I'm not sure, but as far as I know from the https://www.photovoltaikforum.com the piko inverters uses a different API. Perhaps you can try https://www.msxfaq.de/sonst/iot/kostal15.htm. |
i am using this custom right now, not sure if its using the same api, or just webscraping |
The KostalPyko library which is used in their integration uses a different method as the one for the plenticore. |
Make you can integrate it also? That's makes a new integration possible for older invertor too :-) No need for custom then |
I think devices with separate communication libraries should be implemented in separate integrations. I have no possiblity to test other devices. Besides there will be only little common code between the two integrations. |
Ok, np :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First impression is that the integration looks complicated and not in line with our design standards. I would advice to try and simplify this, at least for the first PR. Remove the writing of data and just focus on getting the reading (data fetching) done good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice redesign!
@MartinHjelmare Thank you for the review! I learned a lot. |
What is the status of this PR, @MartinHjelmare? It seems that all requested changes have been done. I'd really love to integrate my Plenticore into HA... |
Sorry, I'll get back to this asap. |
The branch is tainted with unrelated commits now. Please rebase and remove those commits. |
Remove service for write access (for first pull request). Refactor update coordinator to not use the entity API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Proposed change
Adds an integration for Kostal Plenticore solar inverters (https://www.kostal-solar-electric.com/de-de/produkte/solar-wechselrichter/plenticore-plus). This component reads process data and setting values via REST-API and is also capable to change some of the inverter settings (battery minimal SoC for example). It uses a library which was inspired by an app https://github.com/kilianknoll, but the one for this integration uses async requests and has a dynamic data model which allows it to use it with different firmware versions.
Type of change
Example entry for
configuration.yaml
:This component uses Config Flow for configuration. Two information are needed: Host or IP and password.
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: