-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure HA script and Python script services have a name #47204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not handle multiple things in a single PR.
Please strip out the refactoring into a separate PR.
cf5fa00
to
9464cb4
Compare
There is a merge conflict @spacegaier |
Resolved. |
Co-authored-by: Franck Nijhof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only thing missing is tests.
- A test case needs to be added for testing the name parameter in scripts
- A test case needs to be extended for the python_script integration to test the name parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @spacegaier 👍
Breaking change
Proposed change
For HA scripts and Python scripts the backend automatically generates a matching service to trigger them. However, these services currently do not get a name, which however in frontend PR home-assistant/frontend#8493 we would like to show to the user.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
name
property for services.yaml home-assistant.io#16788Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: