Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HA script and Python script services have a name #47204

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Feb 28, 2021

Breaking change

Proposed change

For HA scripts and Python scripts the backend automatically generates a matching service to trigger them. However, these services currently do not get a name, which however in frontend PR home-assistant/frontend#8493 we would like to show to the user.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not handle multiple things in a single PR.
Please strip out the refactoring into a separate PR.

@spacegaier spacegaier force-pushed the script-sservice-name branch from cf5fa00 to 9464cb4 Compare March 29, 2021 23:29
@spacegaier spacegaier requested a review from frenck March 30, 2021 00:17
@frenck
Copy link
Member

frenck commented Mar 30, 2021

There is a merge conflict @spacegaier

@spacegaier
Copy link
Member Author

There is a merge conflict @spacegaier

Resolved.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing missing is tests.

  • A test case needs to be added for testing the name parameter in scripts
  • A test case needs to be extended for the python_script integration to test the name parameter.

@spacegaier spacegaier requested a review from frenck March 31, 2021 13:00
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @spacegaier 👍

@frenck frenck merged commit 6fe04f4 into home-assistant:dev Mar 31, 2021
@spacegaier spacegaier deleted the script-sservice-name branch March 31, 2021 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants