Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homematic HmIP-RCV-1 not found #48659

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix homematic HmIP-RCV-1 not found #48659

merged 1 commit into from
Apr 7, 2021

Conversation

DanielTheCoder
Copy link
Contributor

This change solves that HmIP-RCV-1 is not found when used in a service call to invoke a virtual key (case-sensitivity problem).

Breaking change

  • none

Proposed change

  • Solve case-sensitivity problem for device HMIP-RCV-50 with address HmIP-RCV-1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# example service call
service: homematic.virtualkey
data:
  address: HmIP-RCV-50
   channel: 1
  param: PRESS_SHORT

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

This change solves that HMIP-RCV-1 is not found when used in a service call to invoke a virtual key (case-sensitivity problem).
- https://community.home-assistant.io/t/homematic-hmip-rcv-50-not-working-with-virtual-key-any-more/249000
- https://github.com/danielperna84/pyhomematic/issues/368
@homeassistant
Copy link
Contributor

Hi @DanielTheCoder,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @pvizeli, @danielperna84, mind taking a look at this pull request as its been labeled with an integration (homematic) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Solves that HmIP-RCV-1 is not found when used in a service call to invoke a virtual key (case-sensitivity problem). Fix homematic HmIP-RCV-1 not found Apr 4, 2021
@pvizeli pvizeli merged commit c732749 into home-assistant:dev Apr 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homematic HmIP-RCV-50 not working with virtual key
4 participants