Add zwave_js.bulk_set_partial_config_parameters service #48306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2021
raman325
force-pushed
the
bulk_set_config_parameter
branch
3 times, most recently
from
87f0710 to
f676c3a
Compare
raman325
force-pushed
the
bulk_set_config_parameter
branch
from
6f6ab61 to
1d57129
Compare
|
Do we still need this when we add #48134 ? |
Yes because some devices require multiple partial parameters to be set at the same time, e.g. in a single call |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a new service called
zwave_js.bulk_set_partial_config_parameters. We had originally discussed extending the existingzwave_js.set_config_parameterservice to support this functionality, but it's cleaner to keep it as a separate service and we can document it as being for advanced use. The service accepts either a raw integer value to use for the entire parameter or a mapping of bitmasks to values. In the latter case, the library will calculate the correct integer value to send.This must follow #48094
Additional resources for background:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: