Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hass.io terms in strings.json #48541

Merged
merged 13 commits into from
Mar 31, 2021
Merged

Remove Hass.io terms in strings.json #48541

merged 13 commits into from
Mar 31, 2021

Conversation

LEJOUI
Copy link
Contributor

@LEJOUI LEJOUI commented Mar 31, 2021

Breaking change

Proposed change

In some strings there were a few Hass.io left. This will rename them to Supervisor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
n/a

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @LEJOUI,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as its been labeled with an integration (deconz) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @gcampax, @balloob, mind taking a look at this pull request as its been labeled with an integration (almond) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Kane610
Copy link
Member

Kane610 commented Mar 31, 2021

I don't think supervisor add-on is the proper naming here

@milanmeu
Copy link
Contributor

Many translators ask questions about this on Lokalise.
The translations are inconsistent. The table below shows the translations with corresponding languages for component::mqtt::config::step::hassio_confirm::title.

Translation Languages
Hass.io English, Catalan, Chinese Traditional, Estonian, French, Italian, Korean, Norwegian, Polish
Supervisor Bulgarian, Chinese Simplified, Czech, Danish, Dutch, German, Hungarian, Indonesian, Luxembourgish, Portuguese, Portuguese Brazil, Romanian, Slovenian, Ukrainian, Swedish, Spanish, Spanish Latin America
Home Assistant Russian
Untranslated Afrikaans, Arabic, Armenian, Basque, Bosnian, Croatian, English UK, Esperanto, Finnish, Frisian, Galician, Greek, Hebrew, Hindi, Icelandic, Japanese, Latvian, Lithuanian, Norwegian Bokmål, Norwegian Nynorsk, Persian, Serbian, Serbian Latin, Slovak, Swiss German, Tamil, Telugu, Thai, Turkish, Urdu, Vietnamese, Welsh

homeassistant/components/adguard/strings.json Outdated Show resolved Hide resolved
homeassistant/components/adguard/strings.json Outdated Show resolved Hide resolved
homeassistant/components/almond/strings.json Outdated Show resolved Hide resolved
homeassistant/components/almond/strings.json Outdated Show resolved Hide resolved
homeassistant/components/deconz/strings.json Outdated Show resolved Hide resolved
homeassistant/components/deconz/strings.json Outdated Show resolved Hide resolved
homeassistant/components/mqtt/strings.json Outdated Show resolved Hide resolved
homeassistant/components/mqtt/strings.json Outdated Show resolved Hide resolved
@frenck frenck changed the title Rename Hass.io to Supervisor in strings.json Remove Hass.io terms in strings.json Mar 31, 2021
@frenck frenck merged commit 9392070 into home-assistant:dev Mar 31, 2021
@LEJOUI LEJOUI deleted the patch-1 branch March 31, 2021 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants