-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicates and unexpected failures during roomba discovery #48492
Fix duplicates and unexpected failures during roomba discovery #48492
Conversation
@@ -180,7 +191,7 @@ async def async_step_manual(self, user_input=None): | |||
return self.async_abort(reason="already_configured") | |||
|
|||
self.host = user_input[CONF_HOST] | |||
self.blid = user_input[CONF_BLID] | |||
self.blid = user_input[CONF_BLID].upper() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the BILD is now uppercase and used as a unique ID, should existing entries be migrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing should all be uppercase since we only started getting lowercase data from dhcp in this version (now matches the data coming via zeroconf).
LGTM ✅ |
Thanks! |
Proposed change
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: