Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicates and unexpected failures during roomba discovery #48492

Merged
merged 13 commits into from
Mar 30, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 30, 2021

Proposed change

  • Handles short hostnames (abort duplicate flows)
  • Ensures all BLIDs are uppercases to avoid duplicate setups
  • Retries discovery when the listen server cannot start
  • Retries discovery when roomba has not yet awakened
  • Limits discovery to a single ip address when we know the host from discovery
  • Fix incorrect help url
  • Handle discovery failure case when Home Assistant is on another subnet

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @pschmitt, @cyr-ius, @shenxn, mind taking a look at this pull request as its been labeled with an integration (roomba) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@@ -180,7 +191,7 @@ async def async_step_manual(self, user_input=None):
return self.async_abort(reason="already_configured")

self.host = user_input[CONF_HOST]
self.blid = user_input[CONF_BLID]
self.blid = user_input[CONF_BLID].upper()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the BILD is now uppercase and used as a unique ID, should existing entries be migrated?

Copy link
Member Author

@bdraco bdraco Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing should all be uppercase since we only started getting lowercase data from dhcp in this version (now matches the data coming via zeroconf).

@frenck
Copy link
Member

frenck commented Mar 30, 2021

LGTM ✅

@frenck frenck merged commit e9f2062 into home-assistant:dev Mar 30, 2021
@bdraco
Copy link
Member Author

bdraco commented Mar 30, 2021

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add Roomba when on different subnet
3 participants