update #43
Merged
update #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename TvChannel cluster in TV Linux and Android App * Rename TvChannel cluster in other example apps * Rename TvChannel cluster in src/app folder * Zap regen * Resolved conflicts * Zap Regen zbog conflicts
* [ota-requestor] Switch shell commands to use the common code * Fix build errors * Temporarily workaround undefined definition error Fix undefined definition linker error on ESP32 due to missing definitions from src/app/clusters/ota-requestor. The code can't be enabled due to interference between OTA Provider server, already enabled in all-clusters-app, and OTA Provider client. Co-authored-by: Restyled.io <[email protected]>
…implements to platform path (#13017) * use common codes of ota-requestor cluster in ESP OTA-Requestor app * move OTAImageProcessor and OTARequestorDriver Implement to /src/platform/ * Add OTA implements for darwin platform
They were being passed by const ref in some cases, but also by value, and in a few cases by const value.
…it cannot build NRF (#13078)
#### Problem A review raised questions about failure cases of `IPAddress::FromSockAddr` (see link in the issue for details). Fixes #10800 _IPAddress::FromSockAddr falls through to return Any — is this correct?_ #### Change overview - Replace `FromSockAddr(SockAddr)` with `GetIPAddressFromSockAddr()` with an explicit error return. - Change its main use, `InterfaceIterator::GetAddress()`, to also have an explicit error return. #### Testing CI (`GetAddress` is unit tested).
* [app] use PeerId as the only key for CASESessionManager This prevents accidental misuse of a wrong node in a different fabric. * fix build & review comments
Minor tweak to Darwin templates make them use the right suffixes on literals to make this compile.
* Start adding k32w support for build_examples * Fix typo * Make sure vscode user can actually run the nxp patch sdk script * Ensure all targets exported work, fix names for outputs * Switch k32w CI builds to use example_builds * Support release builds as well * Fix build args duplication * Update targets and builds and unit tests. The build logic is a bit off though * Update unit test and run logic * update cloudbuild to use 0.5.40 build images as well * Restyle files * Fix typo in size info naming * Fix yaml indent typo * One more typo fix * Update to only build release on k32w - it turns out debug does not compile * Restyle files * Increase timeout for k32w example builds
* Replace QPG6100 by the new QPG6105 * Remove commented code * Adjusting chip name in builder scripts * Adjusting chip name in builder scripts - map naming * Correct formatting * Add reference to updated ot-qorvo repo * Remove hardcoded target ic
There were two separate bugs here: 1) For a group write, we were violating the contract for WriteClient::SendWriteRequest, which is that the caller must call Shutdown on failure but the WriteClient itself will do it on success (and call OnDone in the process). We were unconditionally calling Shutdown and OnDone inside SetWriteRequest, even on failure. 2) WriteInteraction was violating the contract for WriteClientHandle::SendWriteRequest, which is different: it always guarantees it will call OnDone. But the consumer was assuming that OnDone would only be called if SendWriteRequest returned success.
* Update ZAP repo * Run ./scripts/tools/zap_convert_all.py
#### Problem Fixes #2698 Once CI supports IPV6, TestTCP/UDP should make the 'EADDRNOTAVAIL' fatal #### Change overview Remove the special handling of `EADDRNOTAVAIL`. #### Testing CI
* Add port config in App Lauch with define flag. * Update examples/placeholder/linux/apps/app1/include/CHIPProjectConfig.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
#### Problem - Heap allocations should use `Platform::New` rather than raw `new`. - `ObjectPoolMem::kStatic` could be misleading, since the pool memory is part of the enclosing context, not static unless also declared `static`. #### Change overview - Use `Platform::New` and `Platform::Delete`. - Rename `ObjectPoolMem::kStatic` → `kInline` and `kDynamic` → `kHeap`. #### Testing CI
#### Problem `reporting::Engine::ScheduleRun()` crashes if invoked after `SessionManager` has shut down. #### Change overview Check pointers. #### Testing Verified using pending PR #13060 with ``` server start server stop exit ``` which crashes without this change.
…n. (#13094) This leads to a weird situation where depending on exactly what the action block does we might throw from the call _and_ queue up an async error report, or maybe we'll just do an async error report. Instead, just reuse our normal async error report machinery to report the error we ran into.
* Convert TestReliableMessageProtocol to using LoopbackMessagingContext. * Use async message delivery in TestReliableMessageProtocol.
The watchdog triggers during crypto tests (long running, full CPU tests) and the warnings it shows both look scary and are not really actionable. We know those tests take a long time, especially in emulation.
* Fix Group Messaging * generated files * zap generation error * comment clean up
* zephyr: Added support for rotating device ID Zephyr platform doesn't support advertising over Bluetooth LE rotating device ID. * Added kconfig option to enable CHIP_ROTATING_DEVICE_ID support * Changed IncrementLifetimeCounter method scope to be implemented by the ConfigurationManager and not in the local Generic manager scope. * Added setting additional data flag in BLE device identification info if additional data advertising is enabled * Added BLE GATT C3 characteristic and support for reading its attribute * Added generating rotating device ID for BLE GATT C3 characteristic * Extracted additional data payload files from the setup payload * Disabled rotating device ID support by default
* Rename time-format & unit cluster to algin with spec * Run codegen
* Added support for all server-side attributes except those marked as 'nice-to-have'. 1. ZAP generator extended to generate pre attribute change callback for Door Lock cluster. 2. Door Lock cluster defines list of attribute change callbacks to be implemented by user and proxies pre attribute change request to the user app. * Added pre-change trap for all unhandled cluster attributes * Update autogenerated files * Fixed restyled-io notes * Fixed CR note (invalid usage of language attribute string) * Fixed CR notes * Fixed return values for pre-attribute change callbacks to make Darwin tests pass. * 1. Fixed bug in DoorLockServer methods: wrong type was used for processing attribute setters' retcode. 2. Implemented empty DoorLockServer methods to set appropriate attributes in the same manner. * Fixed build issue on Infineon: substituted printf type modificators on portable ones from inttypes.h (to prevent printf size mismatch on different platforms) * Enabled SCH and COTA features (attributes and commands) * Update autogenerated files * Fixed arguments in DoorState and LockState accessors * Used chip::to_underlying instead of static_cast for Door Lock enum parameters * Updated autogenerated files * Fix CR note: added size sanity checks for all cluster attributes * Update autogenerated files * Update autogeneretade files * Avoid usage of null-terminated strings 1. Fixed DoorLock cluster to use chip::CharSpan and chip::ByteSpan types instead of C-strings. * Update autogenerated files * Update autogenerated files * Update autogenerated files * Update autogenerated files * Fix zaptool incorrect result * Update autogenerated files * Fix zap-tool incorrect file generation
Everything is using the IM code now.
Also adds verification that a nonempty list is never destroyed, since that would leave dangling pointers back to the list from the nodes that weren't removed from it.
…onLauncher clusters. (#13510)
* [OTA] Update OTA Requestor Server cluster attributes * Address code review comments - Add missing idle updates - Fix logic for setting UpdateStateProgress - Remove OtaRequestorServer class and define the setters as global functions
Signed-off-by: Doru Gucea <[email protected]>
…#13521) It's only written, never read. The emberAfReadSequentialAttributesAddToResponse function that was one of the writers is unused, so removing that too.
Signed-off-by: Victor Morales <[email protected]>
* [chip-tool] Add report-event support to chip-tool * Update generated content
…ommand is unknown (#13529) * [Simulated Device] Print the list of available test commands if the command is unknown * Update generated simulated device code
… image (#13499) * Code for testing bootloader integration * Add bootloader API calls * Add the rest of booloader calls to EFR32 OTA Requestor * Call the OTARequestor Init() method * Use correct booloader API * Close exchange when session is released (#13448) * Close exchange when session is released * Add clearRetransTable parameter to DoClose call Co-authored-by: Andrei Litvin <[email protected]> * Clean up comments and debug code * Restyled by whitespace * Restyled by clang-format Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Fix some grammar/style issues, stop using the deprecated emberAfSendImmediateDefaultResponse API.
* Adding following cluster testcases: 1.TC-MC-5.1 2.TC-MC-5.2 3.TC-MC-5.3 4.TC-MC-6.1 5.TC-MC-6.2 6.TC-MC-6.3 7.TC-MC-6.4 8.TC-MC-7.1 9.TC-MC-7.2 10.TC-MC-8.1 11.TC-MC-9.1 12.TC-LVL-2.2 13.TC-LVL-6.1 Modified following Testcases: 1.TC-LVL-2.1 2.TC-LVL-3.1 3.TC-LVL-4.1 4.TC-LVL-5.1 * Addding auto generated files * Modified Level control testcases * Adding auto generated files of modified testcases * Updating auto generated files. Co-authored-by: Vikram Bhat <[email protected]>
…13540) Error catch on timer broadened to also allow NOT_SYNCED or other errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
What's in this PR
Testing
How was this tested? (at least one bullet point required)