-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to encapsulate a StatusIB in a CHIP_ERROR. #13475
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-error-status
Jan 13, 2022
Merged
Add a way to encapsulate a StatusIB in a CHIP_ERROR. #13475
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-error-status
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
msandstedt and
pan-apple
January 11, 2022 23:05
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
January 11, 2022 23:05
PR #13475: Size comparison from 56ddde0 to eef37fb Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Jan 12, 2022
Fast track: change created and approved by domain owner, has been up for sufficient time for cross-timezone reviews. PR contains unit tests. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have consumers being handed a CHIP_ERROR and a StatusIB, with complicated interactions between the two.
Change overview
Add a way to store a StatusIB in a CHIP_ERROR. Then we can just hand consumers a CHIP_ERROR.
Testing
Unit tests included.