Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zephyr: Added support for rotating device ID #13411

Merged
merged 3 commits into from
Jan 12, 2022
Merged

zephyr: Added support for rotating device ID #13411

merged 3 commits into from
Jan 12, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no commented Jan 10, 2022 •
edited
Loading

Problem

Zephyr platform doesn't support advertising rotating device ID over Bluetooth LE.

Change overview

  • Added kconfig option to enable CHIP_ROTATING_DEVICE_ID support
  • Changed IncrementLifetimeCounter method scope to be implemented by the ConfigurationManager and not in the local Generic manager scope.
  • Added setting additional data flag in BLE device identification info if additional data advertising is enabled
  • Added BLE GATT C3 characteristic and support for reading its attribute
  • Added generating rotating device ID for BLE GATT C3 characteristic

Testing

It was verified that device advertises additional data flag over Bluetooth LE and allows to read rotating device ID from C3 characteristic

@pullapprove pullapprove bot requested a review from yunhanw-google January 10, 2022 13:33
@boring-cyborg boring-cyborg bot added the telink label Jan 10, 2022
@github-actions
Copy link

github-actions bot commented Jan 10, 2022 •
edited
Loading

PR #13411: Size comparison from c396dfa to 30623aa

Increases (14 builds for efr32, esp32, k32w, linux, p6, qpg)
platform target config section c396dfa 30623aa change % change
efr32 lighting-app BRD4161A (read only) 829244 829276 32 0.0
.text 829236 829268 32 0.0
BRD4161A+rpc (read only) 816888 816920 32 0.0
.text 816880 816912 32 0.0
window-app BRD4161A (read only) 802708 802724 16 0.0
.text 802700 802716 16 0.0
esp32 all-clusters-app c3devkit (read only) 891840 891848 8 0.0
(read/write) 1314010 1314018 8 0.0
.flash.rodata 177248 177256 8 0.0
.flash.text 891840 891848 8 0.0
m5stack (read only) 951799 951807 8 0.0
.flash.text 946415 946423 8 0.0
k32w light k32w061+release (read/write) 655308 655312 4 0.0
.text 570884 570888 4 0.0
lock k32w061+release (read/write) 659632 659652 20 0.0
.text 574892 574912 20 0.0
linux chip-tool-ipv6only arm64 (read only) 7105068 7105148 80 0.0
.data.rel.ro 209392 209400 8 0.0
.text 6019636 6019700 64 0.0
thermostat-no-ble arm64 (read only) 2033724 2033804 80 0.0
(read/write) 145089 145105 16 0.0
.data.rel.ro 72624 72632 8 0.0
.text 1691088 1691136 48 0.0
p6 all-clusters-app default (read/write) 2401608 2401632 24 0.0
.text 1359872 1359896 24 0.0
light-app default (read/write) 2323696 2323728 32 0.0
.text 1281960 1281992 32 0.0
lock-app default (read/write) 2295920 2295952 32 0.0
.text 1254184 1254216 32 0.0
qpg lighting-app qpg6105+debug (read only) 533208 533212 4 0.0
.text 527888 527892 4 0.0
lock-app qpg6105+debug (read only) 504984 504988 4 0.0
.text 499664 499668 4 0.0
Full report (15 builds for efr32, esp32, k32w, linux, p6, qpg)
platform target config section c396dfa 30623aa change % change
efr32 lighting-app BRD4161A (read only) 829244 829276 32 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829236 829268 32 0.0
BRD4161A+rpc (read only) 816888 816920 32 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816880 816912 32 0.0
window-app BRD4161A (read only) 802708 802724 16 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802700 802716 16 0.0
esp32 all-clusters-app c3devkit (read only) 891840 891848 8 0.0
(read/write) 1314010 1314018 8 0.0
.dram0.bss 69464 69464 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177248 177256 8 0.0
.flash.text 891840 891848 8 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 951799 951807 8 0.0
(read/write) 445592 445592 0 0.0
.dram0.bss 73960 73960 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 946415 946423 8 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655308 655312 4 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570884 570888 4 0.0
lock k32w061+release (read/write) 659632 659652 20 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574892 574912 20 0.0
linux chip-tool-ipv6only arm64 (read only) 7105068 7105148 80 0.0
(read/write) 327009 327009 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209400 8 0.0
.dynamic 560 560 0 0.0
.got 57968 57968 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388884 388884 0 0.0
.text 6019636 6019700 64 0.0
thermostat-no-ble arm64 (read only) 2033724 2033804 80 0.0
(read/write) 145089 145105 16 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72632 8 0.0
.dynamic 560 560 0 0.0
.got 4000 4000 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 128988 0 0.0
.text 1691088 1691136 48 0.0
p6 all-clusters-app default (read/write) 2401608 2401632 24 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359872 1359896 24 0.0
light-app default (read/write) 2323696 2323728 32 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281960 1281992 32 0.0
lock-app default (read/write) 2295920 2295952 32 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254184 1254216 32 0.0
qpg lighting-app qpg6105+debug (read only) 533208 533212 4 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527888 527892 4 0.0
lock-app qpg6105+debug (read only) 504984 504988 4 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499664 499668 4 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0

@kkasperczyk-no kkasperczyk-no force-pushed the rotating_id_pr branch 2 times, most recently from 2fffa2a to 8963c29 Compare January 10, 2022 19:13
andy31415
andy31415 reviewed Jan 10, 2022
View reviewed changes
src/platform/nrfconnect/BUILD.gn Outdated Show resolved Hide resolved
src/platform/telink/BUILD.gn Outdated Show resolved Hide resolved
@andy31415
Copy link
Contributor

andy31415 commented Jan 10, 2022 •
edited
Loading

@kkasperczyk-no - if possible, please prefer incremental separate commits to force-push as it makes review somewhat easier (can see deltas since last review and comments are not overwritten)

We squash-merge commits, so the master commit will always be only one.

@github-actions
Copy link

github-actions bot commented Jan 10, 2022 •
edited
Loading

PR #13411: Size comparison from 5053f20 to 8963c29

Increases above 0.2%:

platform target config section 5053f20 8963c29 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 108156 108656 500 0.5
text 633432 634708 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923655 925515 1860 0.2
rodata 101580 102080 500 0.5
text 628744 630020 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 848238 850070 1832 0.2
rodata 101328 101832 504 0.5
text 550368 551652 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 909391 911251 1860 0.2
rodata 103428 103928 500 0.5
text 611296 612572 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820562 822422 1860 0.2
rodata 96652 97152 500 0.5
text 528272 529556 1284 0.2
pump-app nrf52840dk_nrf52840 (read/write) 910667 912499 1832 0.2
rodata 103640 104144 504 0.5
text 612512 613788 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 907471 909331 1860 0.2
rodata 102900 103400 500 0.5
text 610044 611320 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5053f20 8963c29 change % change
efr32 lighting-app BRD4161A (read only) 829348 829380 32 0.0
.text 829340 829372 32 0.0
BRD4161A+rpc (read only) 816992 817024 32 0.0
.text 816984 817016 32 0.0
window-app BRD4161A (read only) 802812 802828 16 0.0
.text 802804 802820 16 0.0
esp32 all-clusters-app c3devkit (read only) 890430 890440 10 0.0
.flash.text 890430 890440 10 0.0
m5stack (read only) 950555 950571 16 0.0
(read/write) 445204 445212 8 0.0
.flash.rodata 206164 206172 8 0.0
.flash.text 945171 945187 16 0.0
k32w light k32w061+release (read/write) 655396 655416 20 0.0
.text 570972 570992 20 0.0
lock k32w061+release (read/write) 659736 659740 4 0.0
.text 574996 575000 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7105612 7105708 96 0.0
(read/write) 327041 327057 16 0.0
.data.rel.ro 209424 209432 8 0.0
.text 6020036 6020100 64 0.0
thermostat-no-ble arm64 (read only) 2034188 2034268 80 0.0
.data.rel.ro 72656 72664 8 0.0
.text 1691408 1691472 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2346888 2346896 8 0.0
.text 1309464 1309472 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330856 2330864 8 0.0
.text 1293456 1293464 8 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304008 2304016 8 0.0
.text 1266608 1266616 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937247 939107 1860 0.2
bss 118112 118132 20 0.0
rodata 108156 108656 500 0.5
text 633432 634708 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923655 925515 1860 0.2
bss 115156 115176 20 0.0
rodata 101580 102080 500 0.5
text 628744 630020 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 848238 850070 1832 0.2
bss 116004 116024 20 0.0
rodata 101328 101832 504 0.5
text 550368 551652 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 909391 911251 1860 0.2
bss 117300 117320 20 0.0
rodata 103428 103928 500 0.5
text 611296 612572 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820562 822422 1860 0.2
bss 115220 115240 20 0.0
rodata 96652 97152 500 0.5
text 528272 529556 1284 0.2
pump-app nrf52840dk_nrf52840 (read/write) 910667 912499 1832 0.2
bss 117060 117080 20 0.0
rodata 103640 104144 504 0.5
text 612512 613788 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 907471 909331 1860 0.2
bss 117088 117108 20 0.0
rodata 102900 103400 500 0.5
text 610044 611320 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
bss 109768 109788 20 0.0
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
bss 107656 107676 20 0.0
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
p6 all-clusters-app default (read/write) 2399760 2399776 16 0.0
.text 1358024 1358040 16 0.0
light-app default (read/write) 2323856 2323872 16 0.0
.text 1282120 1282136 16 0.0
lock-app default (read/write) 2296080 2296096 16 0.0
.text 1254344 1254360 16 0.0
qpg lighting-app qpg6105+debug (read only) 533296 533300 4 0.0
.text 527976 527980 4 0.0
lock-app qpg6105+debug (read only) 505072 505076 4 0.0
.text 499752 499756 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 834638 834650 12 0.0
text 582846 582856 10 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5053f20 8963c29 change % change
efr32 lighting-app BRD4161A (read only) 829348 829380 32 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829340 829372 32 0.0
BRD4161A+rpc (read only) 816992 817024 32 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816984 817016 32 0.0
window-app BRD4161A (read only) 802812 802828 16 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802804 802820 16 0.0
esp32 all-clusters-app c3devkit (read only) 890430 890440 10 0.0
(read/write) 1313594 1313594 0 0.0
.dram0.bss 69472 69472 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176816 176816 0 0.0
.flash.text 890430 890440 10 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 950555 950571 16 0.0
(read/write) 445204 445212 8 0.0
.dram0.bss 73968 73968 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206164 206172 8 0.0
.flash.text 945171 945187 16 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655396 655416 20 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570972 570992 20 0.0
lock k32w061+release (read/write) 659736 659740 4 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574996 575000 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7105612 7105708 96 0.0
(read/write) 327041 327057 16 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209424 209432 8 0.0
.dynamic 560 560 0 0.0
.got 57976 57976 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388916 388916 0 0.0
.text 6020036 6020100 64 0.0
thermostat-no-ble arm64 (read only) 2034188 2034268 80 0.0
(read/write) 145137 145137 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72656 72664 8 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 129004 129004 0 0.0
.text 1691408 1691472 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346888 2346896 8 0.0
.bss 188716 188716 0 0.0
.data 5312 5312 0 0.0
.text 1309464 1309472 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330856 2330864 8 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293456 1293464 8 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304008 2304016 8 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266608 1266616 8 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054432 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1017032 1017032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937247 939107 1860 0.2
bss 118112 118132 20 0.0
rodata 108156 108656 500 0.5
text 633432 634708 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923655 925515 1860 0.2
bss 115156 115176 20 0.0
rodata 101580 102080 500 0.5
text 628744 630020 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 848238 850070 1832 0.2
bss 116004 116024 20 0.0
rodata 101328 101832 504 0.5
text 550368 551652 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 909391 911251 1860 0.2
bss 117300 117320 20 0.0
rodata 103428 103928 500 0.5
text 611296 612572 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820562 822422 1860 0.2
bss 115220 115240 20 0.0
rodata 96652 97152 500 0.5
text 528272 529556 1284 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910667 912499 1832 0.2
bss 117060 117080 20 0.0
rodata 103640 104144 504 0.5
text 612512 613788 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 907471 909331 1860 0.2
bss 117088 117108 20 0.0
rodata 102900 103400 500 0.5
text 610044 611320 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
bss 109768 109788 20 0.0
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
bss 107656 107676 20 0.0
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
p6 all-clusters-app default (read/write) 2399760 2399776 16 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1358024 1358040 16 0.0
light-app default (read/write) 2323856 2323872 16 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1282120 1282136 16 0.0
lock-app default (read/write) 2296080 2296096 16 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254344 1254360 16 0.0
qpg lighting-app qpg6105+debug (read only) 533296 533300 4 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527976 527980 4 0.0
lock-app qpg6105+debug (read only) 505072 505076 4 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499752 499756 4 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834638 834650 12 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582846 582856 10 0.0

@kkasperczyk-no
Copy link
Contributor Author

kkasperczyk-no commented Jan 11, 2022 •
edited
Loading

@kkasperczyk-no - if possible, please prefer incremental separate commits to force-push as it makes review somewhat easier (can see deltas since last review and comments are not overwritten)

We squash-merge commits, so the master commit will always be only one.

@andy31415 sure I usually do so, but in this case I wanted only to fix building errors and not address review comments yet. Probably I should have turned it into draft until it's ready instead of force pushing few times.

@kkasperczyk-no
zephyr: Added support for rotating device ID
1bfcf76 
Zephyr platform doesn't support advertising over Bluetooth LE
rotating device ID.

* Added kconfig option to enable CHIP_ROTATING_DEVICE_ID support
* Changed IncrementLifetimeCounter method scope to be implemented
by the ConfigurationManager and not in the local Generic manager
scope.
* Added setting additional data flag in BLE device identification
info if additional data advertising is enabled
* Added BLE GATT C3 characteristic and support for reading its
attribute
* Added generating rotating device ID for BLE GATT C3 characteristic
@restyled-io restyled-io bot mentioned this pull request Jan 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13411: Size comparison from 19f61eb to f74049d

Increases above 0.2%:

platform target config section 19f61eb f74049d change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 108156 108656 500 0.5
text 633348 634624 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923751 925611 1860 0.2
rodata 100604 101104 500 0.5
text 628700 629976 1276 0.2
nrf52840dongle_nrf52840 rodata 112908 113408 500 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 848142 850022 1880 0.2
rodata 101328 101832 504 0.5
text 550272 551556 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 910431 912291 1860 0.2
rodata 103428 103928 500 0.5
text 611212 612488 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820498 822342 1844 0.2
rodata 96652 97152 500 0.5
text 528176 529460 1284 0.2
pump-app nrf52840dk_nrf52840 rodata 103640 104144 504 0.5
text 612424 613700 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 908511 910371 1860 0.2
rodata 102900 103400 500 0.5
text 609960 611236 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 19f61eb f74049d change % change
efr32 lighting-app BRD4161A (read/write) 126996 127000 4 0.0
BRD4161A+rpc (read only) 816112 816124 12 0.0
.text 816104 816116 12 0.0
window-app BRD4161A (read only) 802380 802392 12 0.0
.text 802372 802384 12 0.0
esp32 all-clusters-app c3devkit (read only) 890494 890504 10 0.0
.flash.text 890494 890504 10 0.0
m5stack (read only) 950619 950635 16 0.0
(read/write) 445204 445212 8 0.0
.flash.rodata 206164 206172 8 0.0
.flash.text 945235 945251 16 0.0
k32w light k32w061+release (read/write) 655316 655336 20 0.0
.text 570892 570912 20 0.0
lock k32w061+release (read/write) 659656 659660 4 0.0
.text 574916 574920 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7109708 7109804 96 0.0
(read/write) 327041 327057 16 0.0
.data.rel.ro 209264 209272 8 0.0
.text 6022996 6023060 64 0.0
thermostat-no-ble arm64 (read only) 2031916 2031996 80 0.0
.data.rel.ro 72656 72664 8 0.0
.text 1689136 1689200 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 938287 940147 1860 0.2
bss 119232 119252 20 0.0
rodata 108156 108656 500 0.5
text 633348 634624 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923751 925611 1860 0.2
bss 116276 116296 20 0.0
rodata 100604 101104 500 0.5
text 628700 629976 1276 0.2
nrf52840dongle_nrf52840 (read/write) 988963 990823 1860 0.2
bss 122076 122096 20 0.0
rodata 112908 113408 500 0.4
text 665544 666820 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 848142 850022 1880 0.2
bss 116020 116040 20 0.0
rodata 101328 101832 504 0.5
text 550272 551556 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 910431 912291 1860 0.2
bss 118420 118440 20 0.0
rodata 103428 103928 500 0.5
text 611212 612488 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820498 822342 1844 0.2
bss 115236 115256 20 0.0
rodata 96652 97152 500 0.5
text 528176 529460 1284 0.2
pump-app nrf52840dk_nrf52840 (read/write) 911707 913523 1816 0.2
bss 118180 118200 20 0.0
rodata 103640 104144 504 0.5
text 612424 613700 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 908511 910371 1860 0.2
bss 118208 118228 20 0.0
rodata 102900 103400 500 0.5
text 609960 611236 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
bss 109768 109788 20 0.0
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
bss 107656 107676 20 0.0
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
p6 all-clusters-app default (read/write) 2399760 2399776 16 0.0
.text 1358024 1358040 16 0.0
light-app default (read/write) 2323744 2323752 8 0.0
.text 1282008 1282016 8 0.0
lock-app default (read/write) 2295968 2295984 16 0.0
.text 1254232 1254248 16 0.0
qpg lighting-app qpg6105+debug (read only) 533208 533212 4 0.0
.text 527888 527892 4 0.0
lock-app qpg6105+debug (read only) 504984 504988 4 0.0
.text 499664 499668 4 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106464 16 0.0
.text 101128 101144 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834566 834578 12 0.0
text 582774 582784 10 0.0
Decreases (1 build for efr32)
platform target config section 19f61eb f74049d change % change
efr32 lighting-app BRD4161A (read only) 828916 828912 -4 -0.0
.text 828908 828904 -4 -0.0
Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 19f61eb f74049d change % change
efr32 lighting-app BRD4161A (read only) 828916 828912 -4 -0.0
(read/write) 126996 127000 4 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 828908 828904 -4 -0.0
BRD4161A+rpc (read only) 816112 816124 12 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816104 816116 12 0.0
window-app BRD4161A (read only) 802380 802392 12 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802372 802384 12 0.0
esp32 all-clusters-app c3devkit (read only) 890494 890504 10 0.0
(read/write) 1313594 1313594 0 0.0
.dram0.bss 69472 69472 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176816 176816 0 0.0
.flash.text 890494 890504 10 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 950619 950635 16 0.0
(read/write) 445204 445212 8 0.0
.dram0.bss 73968 73968 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206164 206172 8 0.0
.flash.text 945235 945251 16 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655316 655336 20 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570892 570912 20 0.0
lock k32w061+release (read/write) 659656 659660 4 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574916 574920 4 0.0
linux chip-tool-ipv6only arm64 (read only) 7109708 7109804 96 0.0
(read/write) 327041 327057 16 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209264 209272 8 0.0
.dynamic 560 560 0 0.0
.got 58136 58136 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 389860 389860 0 0.0
.text 6022996 6023060 64 0.0
thermostat-no-ble arm64 (read only) 2031916 2031996 80 0.0
(read/write) 145137 145137 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72656 72664 8 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 129004 129004 0 0.0
.text 1689136 1689200 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 938287 940147 1860 0.2
bss 119232 119252 20 0.0
rodata 108156 108656 500 0.5
text 633348 634624 1276 0.2
nrf52840dk_nrf52840+rpc (read/write) 923751 925611 1860 0.2
bss 116276 116296 20 0.0
rodata 100604 101104 500 0.5
text 628700 629976 1276 0.2
nrf52840dongle_nrf52840 (read/write) 988963 990823 1860 0.2
bss 122076 122096 20 0.0
rodata 112908 113408 500 0.4
text 665544 666820 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 848142 850022 1880 0.2
bss 116020 116040 20 0.0
rodata 101328 101832 504 0.5
text 550272 551556 1284 0.2
lock-app nrf52840dk_nrf52840 (read/write) 910431 912291 1860 0.2
bss 118420 118440 20 0.0
rodata 103428 103928 500 0.5
text 611212 612488 1276 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 820498 822342 1844 0.2
bss 115236 115256 20 0.0
rodata 96652 97152 500 0.5
text 528176 529460 1284 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 911707 913523 1816 0.2
bss 118180 118200 20 0.0
rodata 103640 104144 504 0.5
text 612424 613700 1276 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 908511 910371 1860 0.2
bss 118208 118228 20 0.0
rodata 102900 103400 500 0.5
text 609960 611236 1276 0.2
shell nrf52840dk_nrf52840 (read/write) 798063 800267 2204 0.3
bss 109768 109788 20 0.0
rodata 78180 78720 540 0.7
text 533608 535216 1608 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 710882 713082 2200 0.3
bss 107656 107676 20 0.0
rodata 72484 73020 536 0.7
text 451288 452904 1616 0.4
p6 all-clusters-app default (read/write) 2399760 2399776 16 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1358024 1358040 16 0.0
light-app default (read/write) 2323744 2323752 8 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1282008 1282016 8 0.0
lock-app default (read/write) 2295968 2295984 16 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254232 1254248 16 0.0
qpg lighting-app qpg6105+debug (read only) 533208 533212 4 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527888 527892 4 0.0
lock-app qpg6105+debug (read only) 504984 504988 4 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499664 499668 4 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106464 16 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101144 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834566 834578 12 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582774 582784 10 0.0

@kkasperczyk-no
Copy link
Contributor Author

kkasperczyk-no commented Jan 11, 2022 •
edited
Loading

Pushed commit disabling rotating device ID by default, after verifying that CI passed with this feature enabled.

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13411: Size comparison from 19f61eb to 929f6bb

Increases above 0.2%:

platform target config section 19f61eb 929f6bb change % change
esp32 all-clusters-app c3devkit (read only) 890494 892618 2124 0.2
.dram0.bss 69472 69824 352 0.5
.flash.rodata 176816 177656 840 0.5
.flash.text 890494 892618 2124 0.2
m5stack (read/write) 445204 446360 1156 0.3
.dram0.bss 73968 74304 336 0.5
.flash.rodata 206164 206984 820 0.4
linux thermostat-no-ble arm64 .data.rel.ro 72656 72840 184 0.3
.init_array 296 304 8 2.7
.text 1689136 1693424 4288 0.3
p6 all-clusters-app default .bss 116804 117148 344 0.3
lock-app default .data 2336 2344 8 0.3
qpg lighting-app qpg6105+debug .data 1004 1008 4 0.4
lock-app qpg6105+debug .data 952 956 4 0.4
Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 19f61eb 929f6bb change % change
efr32 lighting-app BRD4161A (read only) 828916 829984 1068 0.1
(read/write) 126996 127056 60 0.0
.bss 125120 125176 56 0.0
.data 1876 1880 4 0.2
.text 828908 829976 1068 0.1
BRD4161A+rpc (read only) 816112 817180 1068 0.1
(read/write) 143656 143716 60 0.0
.bss 141680 141736 56 0.0
.data 1976 1980 4 0.2
.text 816104 817172 1068 0.1
window-app BRD4161A (read only) 802380 803448 1068 0.1
(read/write) 125936 126000 64 0.1
.bss 124104 124160 56 0.0
.data 1832 1836 4 0.2
.text 802372 803440 1068 0.1
esp32 all-clusters-app c3devkit (read only) 890494 892618 2124 0.2
(read/write) 1313594 1314786 1192 0.1
.dram0.bss 69472 69824 352 0.5
.flash.rodata 176816 177656 840 0.5
.flash.text 890494 892618 2124 0.2
m5stack (read only) 950619 952499 1880 0.2
(read/write) 445204 446360 1156 0.3
.dram0.bss 73968 74304 336 0.5
.flash.rodata 206164 206984 820 0.4
.flash.text 945235 947115 1880 0.2
k32w light k32w061+release (read/write) 655316 656152 836 0.1
.bss 76776 76824 48 0.1
.data 1848 1852 4 0.2
.text 570892 571676 784 0.1
lock k32w061+release (read/write) 659656 660492 836 0.1
.bss 77072 77120 48 0.1
.data 1868 1872 4 0.2
.text 574916 575700 784 0.1
linux chip-tool-ipv6only arm64 (read only) 7109708 7113340 3632 0.1
(read/write) 327041 327377 336 0.1
.data.rel.ro 209264 209552 288 0.1
.got 58136 58184 48 0.1
.rodata 389860 390132 272 0.1
.text 6022996 6025604 2608 0.0
thermostat-no-ble arm64 (read only) 2031916 2036652 4736 0.2
(read/write) 145137 145393 256 0.2
.bss 64657 64721 64 0.1
.data.rel.ro 72656 72840 184 0.3
.init_array 296 304 8 2.7
.rodata 129004 129244 240 0.2
.text 1689136 1693424 4288 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2346888 2349504 2616 0.1
.bss 188716 189068 352 0.2
.data 5312 5320 8 0.2
.text 1309464 1312080 2616 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330496 2331144 648 0.0
.bss 180544 180600 56 0.0
.text 1293096 1293744 648 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2303648 2304432 784 0.0
.bss 179592 179648 56 0.0
.text 1266248 1267032 784 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 938287 939007 720 0.1
bss 119232 119284 52 0.0
rodata 108156 108236 80 0.1
text 633348 633924 576 0.1
nrf52840dk_nrf52840+rpc (read/write) 923751 924487 736 0.1
bss 116276 116328 52 0.0
rodata 100604 100684 80 0.1
text 628700 629280 580 0.1
nrf52840dongle_nrf52840 (read/write) 988963 989683 720 0.1
bss 122076 122128 52 0.0
rodata 112908 112988 80 0.1
text 665544 666124 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848142 848878 736 0.1
bss 116020 116072 52 0.0
rodata 101328 101408 80 0.1
text 550272 550848 576 0.1
lock-app nrf52840dk_nrf52840 (read/write) 910431 911295 864 0.1
bss 118420 118472 52 0.0
rodata 103428 103508 80 0.1
text 611212 611920 708 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820498 821330 832 0.1
bss 115236 115288 52 0.0
rodata 96652 96732 80 0.1
text 528176 528884 708 0.1
pump-app nrf52840dk_nrf52840 (read/write) 911707 912571 864 0.1
bss 118180 118232 52 0.0
rodata 103640 103720 80 0.1
text 612424 613180 756 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 908511 909375 864 0.1
bss 118208 118260 52 0.0
rodata 102900 102980 80 0.1
text 609960 610672 712 0.1
shell nrf52840dk_nrf52840 (read/write) 798063 798083 20 0.0
rodata 78180 78184 4 0.0
text 533608 533620 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710902 20 0.0
rodata 72484 72488 4 0.0
text 451288 451296 8 0.0
p6 all-clusters-app default (read/write) 2399760 2402816 3056 0.1
.bss 116804 117148 344 0.3
.text 1358024 1361080 3056 0.2
light-app default (read/write) 2323744 2324808 1064 0.0
.bss 105672 105728 56 0.1
.text 1282008 1283072 1064 0.1
lock-app default (read/write) 2295968 2297040 1072 0.0
.bss 104552 104608 56 0.1
.data 2336 2344 8 0.3
.text 1254232 1255304 1072 0.1
qpg lighting-app qpg6105+debug (read only) 533208 533856 648 0.1
(read/write) 146936 146940 4 0.0
.bss 86624 86672 48 0.1
.data 1004 1008 4 0.4
.text 527888 528536 648 0.1
lock-app qpg6105+debug (read only) 504984 505776 792 0.2
.bss 85760 85808 48 0.1
.data 952 956 4 0.4
.text 499664 500456 792 0.2
persistent-storage-app qpg6105+debug (read only) 106448 106464 16 0.0
.text 101128 101144 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834566 835574 1008 0.1
bss 86924 86976 52 0.1
text 582774 583550 776 0.1
Decreases (1 build for qpg)
platform target config section 19f61eb 929f6bb change % change
qpg lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 19f61eb 929f6bb change % change
efr32 lighting-app BRD4161A (read only) 828916 829984 1068 0.1
(read/write) 126996 127056 60 0.0
.bss 125120 125176 56 0.0
.data 1876 1880 4 0.2
.text 828908 829976 1068 0.1
BRD4161A+rpc (read only) 816112 817180 1068 0.1
(read/write) 143656 143716 60 0.0
.bss 141680 141736 56 0.0
.data 1976 1980 4 0.2
.text 816104 817172 1068 0.1
window-app BRD4161A (read only) 802380 803448 1068 0.1
(read/write) 125936 126000 64 0.1
.bss 124104 124160 56 0.0
.data 1832 1836 4 0.2
.text 802372 803440 1068 0.1
esp32 all-clusters-app c3devkit (read only) 890494 892618 2124 0.2
(read/write) 1313594 1314786 1192 0.1
.dram0.bss 69472 69824 352 0.5
.dram0.data 14244 14244 0 0.0
.flash.rodata 176816 177656 840 0.5
.flash.text 890494 892618 2124 0.2
.iram0.text 62254 62254 0 0.0
m5stack (read only) 950619 952499 1880 0.2
(read/write) 445204 446360 1156 0.3
.dram0.bss 73968 74304 336 0.5
.dram0.data 34064 34064 0 0.0
.flash.rodata 206164 206984 820 0.4
.flash.text 945235 947115 1880 0.2
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655316 656152 836 0.1
.bss 76776 76824 48 0.1
.data 1848 1852 4 0.2
.text 570892 571676 784 0.1
lock k32w061+release (read/write) 659656 660492 836 0.1
.bss 77072 77120 48 0.1
.data 1868 1872 4 0.2
.text 574916 575700 784 0.1
linux chip-tool-ipv6only arm64 (read only) 7109708 7113340 3632 0.1
(read/write) 327041 327377 336 0.1
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209264 209552 288 0.1
.dynamic 560 560 0 0.0
.got 58136 58184 48 0.1
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 389860 390132 272 0.1
.text 6022996 6025604 2608 0.0
thermostat-no-ble arm64 (read only) 2031916 2036652 4736 0.2
(read/write) 145137 145393 256 0.2
.bss 64657 64721 64 0.1
.data 880 880 0 0.0
.data.rel.ro 72656 72840 184 0.3
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 304 8 2.7
.rodata 129004 129244 240 0.2
.text 1689136 1693424 4288 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346888 2349504 2616 0.1
.bss 188716 189068 352 0.2
.data 5312 5320 8 0.2
.text 1309464 1312080 2616 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330496 2331144 648 0.0
.bss 180544 180600 56 0.0
.data 5552 5552 0 0.0
.text 1293096 1293744 648 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303648 2304432 784 0.0
.bss 179592 179648 56 0.0
.data 5544 5544 0 0.0
.text 1266248 1267032 784 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054432 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1017032 1017032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 938287 939007 720 0.1
bss 119232 119284 52 0.0
rodata 108156 108236 80 0.1
text 633348 633924 576 0.1
nrf52840dk_nrf52840+rpc (read/write) 923751 924487 736 0.1
bss 116276 116328 52 0.0
rodata 100604 100684 80 0.1
text 628700 629280 580 0.1
nrf52840dongle_nrf52840 (read/write) 988963 989683 720 0.1
bss 122076 122128 52 0.0
rodata 112908 112988 80 0.1
text 665544 666124 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848142 848878 736 0.1
bss 116020 116072 52 0.0
rodata 101328 101408 80 0.1
text 550272 550848 576 0.1
lock-app nrf52840dk_nrf52840 (read/write) 910431 911295 864 0.1
bss 118420 118472 52 0.0
rodata 103428 103508 80 0.1
text 611212 611920 708 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820498 821330 832 0.1
bss 115236 115288 52 0.0
rodata 96652 96732 80 0.1
text 528176 528884 708 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 911707 912571 864 0.1
bss 118180 118232 52 0.0
rodata 103640 103720 80 0.1
text 612424 613180 756 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 908511 909375 864 0.1
bss 118208 118260 52 0.0
rodata 102900 102980 80 0.1
text 609960 610672 712 0.1
shell nrf52840dk_nrf52840 (read/write) 798063 798083 20 0.0
bss 109768 109768 0 0.0
rodata 78180 78184 4 0.0
text 533608 533620 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710902 20 0.0
bss 107656 107656 0 0.0
rodata 72484 72488 4 0.0
text 451288 451296 8 0.0
p6 all-clusters-app default (read/write) 2399760 2402816 3056 0.1
.bss 116804 117148 344 0.3
.data 2592 2592 0 0.0
.text 1358024 1361080 3056 0.2
light-app default (read/write) 2323744 2324808 1064 0.0
.bss 105672 105728 56 0.1
.data 2384 2384 0 0.0
.text 1282008 1283072 1064 0.1
lock-app default (read/write) 2295968 2297040 1072 0.0
.bss 104552 104608 56 0.1
.data 2336 2344 8 0.3
.text 1254232 1255304 1072 0.1
qpg lighting-app qpg6105+debug (read only) 533208 533856 648 0.1
(read/write) 146936 146940 4 0.0
.bss 86624 86672 48 0.1
.data 1004 1008 4 0.4
.text 527888 528536 648 0.1
lock-app qpg6105+debug (read only) 504984 505776 792 0.2
(read/write) 146940 146936 -4 -0.0
.bss 85760 85808 48 0.1
.data 952 956 4 0.4
.text 499664 500456 792 0.2
persistent-storage-app qpg6105+debug (read only) 106448 106464 16 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101144 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834566 835574 1008 0.1
bss 86924 86976 52 0.1
noinit 37160 37160 0 0.0
text 582774 583550 776 0.1

LuDuda
LuDuda approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andy31415 andy31415 merged commit 6bb25d5 into project-chip:master Jan 12, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@kkasperczyk-no @selissia
zephyr: Added support for rotating device ID (project-chip#13411)
8fb28e6 
* zephyr: Added support for rotating device ID

Zephyr platform doesn't support advertising over Bluetooth LE
rotating device ID.

* Added kconfig option to enable CHIP_ROTATING_DEVICE_ID support
* Changed IncrementLifetimeCounter method scope to be implemented
by the ConfigurationManager and not in the local Generic manager
scope.
* Added setting additional data flag in BLE device identification
info if additional data advertising is enabled
* Added BLE GATT C3 characteristic and support for reading its
attribute
* Added generating rotating device ID for BLE GATT C3 characteristic

* Extracted additional data payload files from the setup payload

* Disabled rotating device ID support by default
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@kkasperczyk-no @step0035
zephyr: Added support for rotating device ID (project-chip#13411)
9c75182 
* zephyr: Added support for rotating device ID

Zephyr platform doesn't support advertising over Bluetooth LE
rotating device ID.

* Added kconfig option to enable CHIP_ROTATING_DEVICE_ID support
* Changed IncrementLifetimeCounter method scope to be implemented
by the ConfigurationManager and not in the local Generic manager
scope.
* Added setting additional data flag in BLE device identification
info if additional data advertising is enabled
* Added BLE GATT C3 characteristic and support for reading its
attribute
* Added generating rotating device ID for BLE GATT C3 characteristic

* Extracted additional data payload files from the setup payload

* Disabled rotating device ID support by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
config nrf connect platform review - approved setup payload telink zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkasperczyk-no @andy31415 @mspang @LuDuda @bzbarsky-apple