-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove time source template argument of sessions #12791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kghost
changed the title
Session no template
Remove time source template argument of sessions
Dec 9, 2021
kghost
force-pushed
the
session-no-template
branch
from
December 9, 2021 13:31
1d2c44d
to
b6ff4e2
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
December 9, 2021 13:32
PR #12791: Size comparison from 8adecf7 to b6ff4e2 Increases (8 builds for k32w, linux, qpg, telink)
Decreases (8 builds for k32w, linux, qpg, telink)
Full report (9 builds for k32w, linux, qpg, telink)
|
kghost
force-pushed
the
session-no-template
branch
from
December 9, 2021 13:59
b6ff4e2
to
926198b
Compare
PR #12791: Size comparison from 564fa06 to 926198b Increases (11 builds for k32w, linux, p6, qpg, telink)
Decreases (14 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
kghost
force-pushed
the
session-no-template
branch
from
December 9, 2021 15:35
926198b
to
2b17748
Compare
andy31415
approved these changes
Dec 9, 2021
PR #12791: Size comparison from f2e7df8 to 2b17748 Increases (24 builds for k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (24 builds for k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (27 builds for k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
Byungjoo-Lee,
chshu,
dhrishi,
gjc13 and
xylophone21
December 9, 2021 19:55
kghost
force-pushed
the
session-no-template
branch
from
December 10, 2021 05:28
2b17748
to
3fc0620
Compare
PR #12791: Size comparison from 0c5b08d to 3fc0620 Increases (7 builds for mbed, p6)
Decreases (20 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
kghost
force-pushed
the
session-no-template
branch
from
December 16, 2021 05:53
3fc0620
to
3f0bf89
Compare
PR #12791: Size comparison from 161cd14 to 3f0bf89 Increases (1 build for mbed)
Decreases (20 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
kghost
force-pushed
the
session-no-template
branch
from
December 16, 2021 09:27
3f0bf89
to
53f5781
Compare
PR #12791: Size comparison from 41700bd to 53f5781 Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Remove time source template argument of sessions
This helps unify interface of all types of sessions.
Change overview
Remove time source template argument of sessions
Testing
No actual change. Using unit-tests