-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[app] use PeerId as the only key for CASESessionManager #13074
Merged
andy31415
merged 2 commits into
project-chip:master
from
gjc13:case-manager-only-peerid
Dec 16, 2021
Merged
[app] use PeerId as the only key for CASESessionManager #13074
andy31415
merged 2 commits into
project-chip:master
from
gjc13:case-manager-only-peerid
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple and
robszewczyk
December 16, 2021 05:58
pullapprove
bot
requested review from
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
December 16, 2021 05:58
PR #13074: Size comparison from 161cd14 to e073bb3 Increases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #13074: Size comparison from 161cd14 to 7e2cc27 Increases (17 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
This prevents accidental misuse of a wrong node in a different fabric.
gjc13
force-pushed
the
case-manager-only-peerid
branch
from
December 16, 2021 09:18
7e2cc27
to
7db565c
Compare
PR #13074: Size comparison from 9a595a4 to 7db565c Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 16, 2021
andy31415
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some API of
CASESessionManager
takes onlyNodeId
and can accidentaly match a node in a different fabric.Change overview
The
CASESessionManager
class is modified to accept onlyPeerId
for accessing nodes.Testing
Tested with ota requestor & provider