-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Maintains multiple commissioners alive at the same time i… #13033
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_MultipleCommissioners
Dec 16, 2021
Merged
[chip-tool] Maintains multiple commissioners alive at the same time i… #13033
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_MultipleCommissioners
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns and
msandstedt
December 15, 2021 14:43
pullapprove
bot
requested review from
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple and
xylophone21
December 15, 2021 14:43
PR #13033: Size comparison from 8bedafa to e92c465 Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (8 builds for mbed, p6, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 15, 2021
msandstedt
reviewed
Dec 15, 2021
bzbarsky-apple
approved these changes
Dec 15, 2021
vivien-apple
force-pushed
the
ChipTool_MultipleCommissioners
branch
from
December 16, 2021 09:00
e92c465
to
316c37e
Compare
PR #13033: Size comparison from 9a595a4 to 316c37e Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (4 builds for p6, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n chip-tool
Problem
In order to write multi-admin tests, multiple commissioners are needed in
chip-tool
Change overview