Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh subscription liveness after processing subscribe response #13519

Conversation

yunhanw-google
Copy link
Contributor

Problem

Subscription liveness timer does not run after subscription is established. Currently liveness timer is running after report is accepted during post-subscription.

Change overview

Call RefreshLivenessCheckTimer after we complete subscription response processing.

Testing

Manually observe the liveness timer is running after subscription is established.

@github-actions
Copy link

github-actions bot commented Jan 13, 2022

PR #13519: Size comparison from 60347b6 to b62b08d

Increases (1 build for linux)
platform target config section 60347b6 b62b08d change % change
linux chip-tool-ipv6only arm64 (read only) 7215212 7215244 32 0.0
.text 6089508 6089540 32 0.0
Decreases (1 build for esp32)
platform target config section 60347b6 b62b08d change % change
esp32 all-clusters-app m5stack (read only) 957187 957183 -4 -0.0
.flash.text 951803 951799 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 60347b6 b62b08d change % change
efr32 lighting-app BRD4161A (read only) 831200 831200 0 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 831192 831192 0 0.0
BRD4161A+rpc (read only) 818604 818604 0 0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 818596 818596 0 0.0
window-app BRD4161A (read only) 805096 805096 0 0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 805088 805088 0 0.0
esp32 all-clusters-app c3devkit (read only) 908440 908440 0 0.0
(read/write) 1316058 1316058 0 0.0
.dram0.bss 70176 70176 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178112 178112 0 0.0
.flash.text 908440 908440 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 957187 957183 -4 -0.0
(read/write) 448216 448216 0 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207384 207384 0 0.0
.flash.text 951803 951799 -4 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656952 656952 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572476 572476 0 0.0
lock k32w061+release (read/write) 661252 661252 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576460 576460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7215212 7215244 32 0.0
(read/write) 345921 345921 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 227824 227824 0 0.0
.dynamic 560 560 0 0.0
.got 58440 58440 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392436 392436 0 0.0
.text 6089508 6089540 32 0.0
thermostat-no-ble arm64 (read only) 2039628 2039628 0 0.0
(read/write) 145617 145617 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129756 129756 0 0.0
.text 1695312 1695312 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346192 2346192 0 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1308768 1308768 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331160 2331160 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293760 1293760 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304384 2304384 0 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266984 1266984 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054392 2054392 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016992 1016992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939923 939923 0 0.0
bss 119284 119284 0 0.0
rodata 108544 108544 0 0.0
text 634532 634532 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925387 925387 0 0.0
bss 116328 116328 0 0.0
rodata 100992 100992 0 0.0
text 629884 629884 0 0.0
nrf52840dongle_nrf52840 (read/write) 990599 990599 0 0.0
bss 122128 122128 0 0.0
rodata 113296 113296 0 0.0
text 666728 666728 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849778 849778 0 0.0
bss 116072 116072 0 0.0
rodata 101716 101716 0 0.0
text 551452 551452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912195 912195 0 0.0
bss 118472 118472 0 0.0
rodata 103816 103816 0 0.0
text 612524 612524 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822230 822230 0 0.0
bss 115288 115288 0 0.0
rodata 97040 97040 0 0.0
text 529484 529484 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913487 913487 0 0.0
bss 118232 118232 0 0.0
rodata 104028 104028 0 0.0
text 613784 613784 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910275 910275 0 0.0
bss 118260 118260 0 0.0
rodata 103288 103288 0 0.0
text 611272 611272 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798627 798627 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533968 533968 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711446 711446 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451648 451648 0 0.0
p6 all-clusters-app default (read/write) 2400272 2400272 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1358536 1358536 0 0.0
light-app default (read/write) 2325968 2325968 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1284232 1284232 0 0.0
lock-app default (read/write) 2298200 2298200 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1256464 1256464 0 0.0
qpg lighting-app qpg6105+debug (read only) 535004 535004 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89024 89024 0 0.0
.data 1008 1008 0 0.0
.text 529684 529684 0 0.0
lock-app qpg6105+debug (read only) 506908 506908 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88160 88160 0 0.0
.data 956 956 0 0.0
.text 501588 501588 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836510 836510 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 584166 584166 0 0.0

@yufengwangca yufengwangca merged commit f700ac9 into project-chip:master Jan 13, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants