Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Verhoeff algorithm check/generate in chip-tool #13048

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add Verhoeff algorithm check/generate in chip-tool #13048

merged 1 commit into from
Dec 16, 2021

Conversation

krypton36
Copy link
Contributor

Problem

Add Verhoeff algorithm check/generate for the following issue #13025

Change overview

  • Adds check/generate of the Verhoeff from lib/support

Testing

Tested using chip-tool and generated manual pairing code.

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13048: Size comparison from 89aff25 to b1a92f8

Increases (1 build for linux)
platform target config section 89aff25 b1a92f8 change % change
linux chip-tool-ipv6only arm64 (read only) 6979836 6982068 2232 0.0
(read/write) 324609 324705 96 0.0
.data.rel.ro 208392 208472 80 0.0
.got 55520 55536 16 0.0
.rodata 376348 376572 224 0.1
.text 5917428 5919204 1776 0.0
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 89aff25 b1a92f8 change % change
efr32 lighting-app BRD4161A (read only) 840592 840592 0 0.0
(read/write) 128640 128640 0 0.0
.bss 126760 126760 0 0.0
.data 1876 1876 0 0.0
.text 840584 840584 0 0.0
BRD4161A+rpc (read only) 828196 828196 0 0.0
(read/write) 145312 145312 0 0.0
.bss 143336 143336 0 0.0
.data 1976 1976 0 0.0
.text 828188 828188 0 0.0
window-app BRD4161A (read only) 813968 813968 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813960 813960 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 691148 691148 0 0.0
.bss 79344 79344 0 0.0
.data 1908 1908 0 0.0
.text 604096 604096 0 0.0
lock-app k32w061+debug (read/write) 638712 638712 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553556 553556 0 0.0
shell k32w061+debug (read/write) 644100 644100 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556656 556656 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979836 6982068 2232 0.0
(read/write) 324609 324705 96 0.0
.bss 55905 55905 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208472 80 0.0
.dynamic 560 560 0 0.0
.got 55520 55536 16 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376348 376572 224 0.1
.text 5917428 5919204 1776 0.0
thermostat-no-ble arm64 (read only) 2008724 2008724 0 0.0
(read/write) 145297 145297 0 0.0
.bss 65649 65649 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128068 128068 0 0.0
.text 1669120 1669120 0 0.0
p6 all-clusters-app default (read/write) 2394600 2394600 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1352864 1352864 0 0.0
light-app default (read/write) 2334912 2334912 0 0.0
.bss 107448 107448 0 0.0
.data 2384 2384 0 0.0
.heap 923512 923512 0 0.0
.text 1293176 1293176 0 0.0
lock-app default (read/write) 2307128 2307128 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1265392 1265392 0 0.0
qpg lighting-app qpg6105+debug (read only) 536144 536144 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 1004 1004 0 0.0
.text 530824 530824 0 0.0
lock-app qpg6105+debug (read only) 507832 507832 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502512 502512 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836574 836574 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 583428 583428 0 0.0

@krypton36 krypton36 force-pushed the AddVerhoeffChipTool branch 2 times, most recently from e703f83 to be5e837 Compare December 15, 2021 21:56
@github-actions
Copy link

PR #13048: Size comparison from 9a74bae to be5e837

Full report (1 build for telink)
platform target config section 9a74bae be5e837 change % change
telink lighting-app tlsr9518adk80d (read/write) 831110 831110 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 579422 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13048: Size comparison from 9a74bae to 0edb6e2

Increases (1 build for linux)
platform target config section 9a74bae 0edb6e2 change % change
linux chip-tool-ipv6only arm64 (read only) 6911556 6913692 2136 0.0
(read/write) 322993 323089 96 0.0
.data.rel.ro 207752 207832 80 0.0
.got 55864 55880 16 0.0
.rodata 377636 377860 224 0.1
.text 5847924 5849604 1680 0.0
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 9a74bae 0edb6e2 change % change
efr32 lighting-app BRD4161A (read only) 835748 835748 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835740 835740 0 0.0
BRD4161A+rpc (read only) 823352 823352 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823344 823344 0 0.0
window-app BRD4161A (read only) 809108 809108 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809100 809100 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686412 686412 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600680 600680 0 0.0
lock-app k32w061+debug (read/write) 633976 633976 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550140 550140 0 0.0
shell k32w061+debug (read/write) 639720 639720 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553396 553396 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6911556 6913692 2136 0.0
(read/write) 322993 323089 96 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207752 207832 80 0.0
.dynamic 560 560 0 0.0
.got 55864 55880 16 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377860 224 0.1
.text 5847924 5849604 1680 0.0
thermostat-no-ble arm64 (read only) 1994052 1994052 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654672 1654672 0 0.0
p6 all-clusters-app default (read/write) 2389688 2389688 0 0.0
.bss 117212 117212 0 0.0
.data 2536 2536 0 0.0
.heap 913592 913592 0 0.0
.text 1347952 1347952 0 0.0
light-app default (read/write) 2330000 2330000 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.heap 924832 924832 0 0.0
.text 1288264 1288264 0 0.0
lock-app default (read/write) 2302192 2302192 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.heap 926000 926000 0 0.0
.text 1260456 1260456 0 0.0
qpg lighting-app qpg6105+debug (read only) 532768 532768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527448 527448 0 0.0
lock-app qpg6105+debug (read only) 504456 504456 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499136 499136 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831110 831110 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 579422 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13048: Size comparison from fc5be12 to b2b96cd

Increases (1 build for linux)
platform target config section fc5be12 b2b96cd change % change
linux chip-tool-ipv6only arm64 (read only) 6911556 6913692 2136 0.0
(read/write) 322993 323089 96 0.0
.data.rel.ro 207752 207832 80 0.0
.got 55864 55880 16 0.0
.rodata 377636 377860 224 0.1
.text 5847924 5849604 1680 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fc5be12 b2b96cd change % change
efr32 lighting-app BRD4161A (read only) 835748 835748 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835740 835740 0 0.0
BRD4161A+rpc (read only) 823352 823352 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823344 823344 0 0.0
window-app BRD4161A (read only) 809108 809108 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809100 809100 0 0.0
esp32 all-clusters-app c3devkit (read only) 876014 876014 0 0.0
(read/write) 1312770 1312770 0 0.0
.dram0.bss 69752 69752 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 175776 175776 0 0.0
.flash.text 876014 876014 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961915 961915 0 0.0
(read/write) 453524 453524 0 0.0
.dram0.bss 76080 76080 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 211600 211600 0 0.0
.flash.text 956531 956531 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686412 686412 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600680 600680 0 0.0
lock-app k32w061+debug (read/write) 633976 633976 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550140 550140 0 0.0
shell k32w061+debug (read/write) 639720 639720 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553396 553396 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6911556 6913692 2136 0.0
(read/write) 322993 323089 96 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207752 207832 80 0.0
.dynamic 560 560 0 0.0
.got 55864 55880 16 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377860 224 0.1
.text 5847924 5849604 1680 0.0
thermostat-no-ble arm64 (read only) 1994052 1994052 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654672 1654672 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333776 2333776 0 0.0
.bss 189020 189020 0 0.0
.data 5256 5256 0 0.0
.text 1296352 1296352 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329344 2329344 0 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291944 1291944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302376 0 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1264976 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936579 936579 0 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632668 632668 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 918531 918531 0 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625804 625804 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860294 860294 0 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560100 560100 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908675 908675 0 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610484 610484 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832622 832622 0 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537956 537956 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913555 913555 0 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 614036 614036 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906787 906787 0 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609232 609232 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2389688 2389688 0 0.0
.bss 117212 117212 0 0.0
.data 2536 2536 0 0.0
.text 1347952 1347952 0 0.0
light-app default (read/write) 2330000 2330000 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288264 1288264 0 0.0
lock-app default (read/write) 2302192 2302192 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260456 1260456 0 0.0
qpg lighting-app qpg6105+debug (read only) 532768 532768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527448 527448 0 0.0
lock-app qpg6105+debug (read only) 504456 504456 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499136 499136 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831110 831110 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 579422 0 0.0

@andy31415 andy31415 merged commit efe5037 into project-chip:master Dec 16, 2021
@franck-apple franck-apple mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krypton36 @andy31415 @bzbarsky-apple