-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PASE state machine's state after successful send #13090
Merged
andy31415
merged 1 commit into
project-chip:master
from
pan-apple:set-pase-state-after-send
Dec 16, 2021
Merged
Update PASE state machine's state after successful send #13090
andy31415
merged 1 commit into
project-chip:master
from
pan-apple:set-pase-state-after-send
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
sagar-apple and
saurabhst
December 16, 2021 17:22
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
December 16, 2021 17:22
msandstedt
approved these changes
Dec 16, 2021
PR #13090: Size comparison from 8e40abc to a65bead Increases (5 builds for esp32, k32w, qpg)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 16, 2021
bzbarsky-apple
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
mNextExpectedMsg
is updated before the message is successfully transmitted. This was done due to limitations in the unit test infrastructure (as the response was received synchronously). That code has been modified to receive responses as async. So, the PASESession state machine should be fixed to update the state only after successful transmission of the message.Change overview
Updated PASESession state machine code.
Testing
TestPASESession
covers all the test conditions. It used to fail with this change when the responses were received synchronously. The test suite is passing now.