-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some names in Dnssd to be more consistent across the board #13083
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DNSSD_PlatformNamingWithMacros
Dec 16, 2021
Merged
Update some names in Dnssd to be more consistent across the board #13083
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DNSSD_PlatformNamingWithMacros
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02 and
mlepage-google
December 16, 2021 14:54
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
December 16, 2021 14:54
andy31415
approved these changes
Dec 16, 2021
msandstedt
reviewed
Dec 16, 2021
msandstedt
approved these changes
Dec 16, 2021
PR #13083: Size comparison from 91a1a5c to 543bb19 Increases (10 builds for efr32, nrfconnect)
Decreases (16 builds for efr32, k32w, nrfconnect, qpg)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a lot of code duplicated into
Discovery_ImplPlatform.cpp
and the dnssd naming for methods and variables is not always consistent which makes it harder to read than what it should be.The 2 methods that I have focused on in this PR are the
Advertise
methods, both for operation and commissionable nodes.Change overview
Discovery_ImplPlatform.cpp
code to benefit from those consistent names and use some macros to help readability.Testing
I have locally checked that discovering the node over mdns is still successful.