Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Flag @kbn/config-schema as server-only #189476

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

afharo
Copy link
Member

@afharo afharo commented Jul 30, 2024

Summary

After #188606, let's enforce @kbn/config-schema to be a shared-server to ensure that it never leaks to the browser anymore.

To make reviews easier, I'll apply the fixes in separate PRs, and keep rebasing this one until the CI is green. Not setting it as draft to avoid having to comment /ci on every push. Reviewers, feel free to unsubscribe from the notifications. I'll ping you once it's all ready.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 30, 2024
@afharo afharo self-assigned this Jul 30, 2024
@afharo afharo requested a review from a team as a code owner July 30, 2024 08:57
@afharo afharo added the technical debt Improvement of the software architecture and operational architecture label Jul 30, 2024
@afharo
Copy link
Member Author

afharo commented Aug 9, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 30, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants