-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Flag @kbn/config-schema
as server-only
#189476
Open
afharo
wants to merge
8
commits into
elastic:main
Choose a base branch
from
afharo:config-schema-as-server-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
labels
Jul 30, 2024
afharo
added
the
technical debt
Improvement of the software architecture and operational architecture
label
Jul 30, 2024
This was referenced Jul 30, 2024
1 task
/ci |
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
1 task
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
technical debt
Improvement of the software architecture and operational architecture
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #188606, let's enforce
@kbn/config-schema
to be ashared-server
to ensure that it never leaks to the browser anymore.To make reviews easier, I'll apply the fixes in separate PRs, and keep rebasing this one until the CI is green. Not setting it as draft to avoid having to comment
/ci
on every push. Reviewers, feel free to unsubscribe from the notifications. I'll ping you once it's all ready.For maintainers