Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move @kbn/config-schema to server] data_views #191516

Closed

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 27, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and config.ts should be part of the server logic.

For maintainers

@afharo afharo requested a review from a team as a code owner August 27, 2024 15:43
@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Aug 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@afharo afharo self-assigned this Aug 27, 2024
@afharo afharo enabled auto-merge (squash) August 27, 2024 15:44
@afharo afharo added the technical debt Improvement of the software architecture and operational architecture label Aug 27, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataViews 53 52 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo
Copy link
Member Author

afharo commented Aug 27, 2024

Close in favor of #191521

@afharo afharo closed this Aug 27, 2024
auto-merge was automatically disabled August 27, 2024 18:13

Pull request was closed

@afharo afharo deleted the move-config-schema-to-server/data_views branch August 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants