Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] transform #191685

Merged
merged 2 commits into from
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] transform #191685

merged 2 commits into from
Aug 29, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

For maintainers

@afharo afharo added Team:QA Team label for QA Team :ml technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:ML Team label for ML (also use :ml) Team:obs-ux-management Observability Management User Experience Team labels Aug 28, 2024
@afharo afharo requested review from a team as code owners August 28, 2024 23:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:29
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wayneseymour
wayneseymour approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR only, LGTM

@walterra walterra self-requested a review August 29, 2024 08:28
ymao1
ymao1 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm

walterra
walterra approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up!

@afharo afharo merged commit b36b198 into elastic:main Aug 29, 2024
20 checks passed
@afharo afharo deleted the move-config-schema-to-server/transform branch August 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@wayneseymour wayneseymour wayneseymour approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) Team:obs-ux-management Observability Management User Experience Team Team:QA Team label for QA Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@afharo @elasticmachine @kibana-ci @walterra @shahzad31 @wayneseymour @ymao1 @kibanamachine