Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] kbn-server-http-tools #191687

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] kbn-server-http-tools #191687

merged 3 commits into from
Aug 29, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 28, 2024
@afharo afharo requested a review from a team as a code owner August 28, 2024 23:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:46
TinaHeiligers
TinaHeiligers approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo requested a review from a team as a code owner August 29, 2024 00:59
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 29, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 972d12c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191687-972d12ce3688

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 196dccd into elastic:main Aug 29, 2024
25 checks passed
@afharo afharo deleted the move-config-schema-to-server/kbn-server-http-tools branch August 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:obs-ux-management Observability Management User Experience Team technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afharo @elasticmachine @kibana-ci @shahzad31 @TinaHeiligers @kibanamachine