Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] home #191780

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Move @kbn/config-schema to server] home #191780

merged 1 commit into from
Aug 30, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 29, 2024
@afharo afharo requested review from a team as code owners August 29, 2024 22:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@afharo afharo enabled auto-merge (squash) August 29, 2024 22:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dosant
Copy link
Contributor

Dosant commented Aug 30, 2024

Not sure why CI doesn't report bundle sizes 😢

@afharo
Copy link
Member Author

afharo commented Aug 30, 2024

Not sure why CI doesn't report bundle sizes 😢

I think the bundles didn't import anything runtime from the file and didn't leak. This work is in preparation to avoid any future leaks (that have already happened and fixed before).

@afharo afharo merged commit 6ce2d6b into elastic:main Aug 30, 2024
27 checks passed
@afharo afharo deleted the move-config-schema-to-server/home branch August 30, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoldevila gsoldevila gsoldevila approved these changes

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afharo @elasticmachine @kibana-ci @Dosant @gsoldevila @kibanamachine