Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move @kbn/config-schema to server] kbn-object-versioning #191691

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Aug 29, 2024
@afharo afharo requested a review from a team as a code owner August 29, 2024 00:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@afharo afharo enabled auto-merge (squash) August 29, 2024 00:16
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
contentManagement 18 19 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/object-versioning-utils - 2 +2
Unknown metric groups

API count

id before after diff
@kbn/object-versioning-utils - 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 52cbd49 into elastic:main Aug 29, 2024
39 checks passed
@afharo afharo deleted the move-config-schema-to-server/kbn-object-versioning branch August 29, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants