Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] maps #191523

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[Move @kbn/config-schema to server] maps #191523

merged 1 commit into from
Aug 27, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 27, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Geo labels Aug 27, 2024
@afharo afharo self-assigned this Aug 27, 2024
@afharo afharo requested a review from a team as a code owner August 27, 2024 16:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@afharo afharo enabled auto-merge (squash) August 27, 2024 16:24
nreese
nreese approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review only

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit e2a0381 into elastic:main Aug 27, 2024
29 checks passed
@afharo afharo deleted the move-config-schema-to-server/maps branch August 27, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees

@afharo afharo

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Geo technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @kibana-ci @nreese @kibanamachine