Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] presentation plugins #191776

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] presentation plugins #191776

merged 1 commit into from
Aug 29, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and these plugins are using it outside the ./server directory.

For maintainers

@afharo afharo added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 29, 2024
@afharo afharo requested a review from a team as a code owner August 29, 2024 22:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@afharo afharo enabled auto-merge (squash) August 29, 2024 22:03
Heenawter
Heenawter approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - code review only 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 2604f35 into elastic:main Aug 29, 2024
26 checks passed
@afharo afharo deleted the move-config-schema-to-server/presentation-plugins branch August 29, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @kibana-ci @Heenawter @kibanamachine