Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] alerting #191851

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Move @kbn/config-schema to server] alerting #191851

wants to merge 2 commits into from

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 30, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

I found that the UI only references this code via import type, so I don't expect it to have any impact on bundle metrics, but this PR is still useful to avoid potential future leaks.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 30, 2024
@afharo afharo requested a review from a team as a code owner August 30, 2024 15:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@afharo afharo enabled auto-merge (squash) August 30, 2024 15:06
@afharo afharo requested review from a team as code owners August 30, 2024 16:54
@afharo afharo requested a review from nkhristinin August 30, 2024 16:54
@afharo afharo added Team:Detection Engine Security Solution Detection Engine Area Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-management Observability Management User Experience Team labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

nkhristinin
nkhristinin reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, security solution UI we import types from this plugin, especially for backfill docs. Do you think moving it's to server and import on public plugin is ok?

pmuellr
pmuellr approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after chat with team

@afharo afharo marked this pull request as draft December 12, 2024 23:05
auto-merge was automatically disabled December 12, 2024 23:05

Pull request was converted to draft

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@cnasikas cnasikas mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin left review comments

@pmuellr pmuellr pmuellr approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-management Observability Management User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afharo @elasticmachine @kibana-ci @pmuellr @nkhristinin @dominiqueclarke