Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move @kbn/config-schema to server] unified_search #191773

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Move @kbn/config-schema to server] unified_search #191773

merged 1 commit into from
Aug 30, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Aug 29, 2024
@afharo afharo requested review from a team as code owners August 29, 2024 21:11
@afharo afharo requested review from ashokaditya and parkiino August 29, 2024 21:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@afharo afharo enabled auto-merge (squash) August 29, 2024 21:11
nickofthyme
nickofthyme approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis code changes LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ymao1
ymao1 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm. code review only.

@afharo afharo merged commit 232d7cf into elastic:main Aug 30, 2024
52 checks passed
@afharo afharo deleted the move-config-schema-to-server/unified_search branch August 30, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@ymao1 ymao1 ymao1 approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@afharo @elasticmachine @kibana-ci @ashokaditya @ymao1 @nickofthyme @kibanamachine