Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move @kbn/config-schema to server] @kbn/search-connectors #191838

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 30, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package is using it while being shared-common.

The class ByteSizeValue (used by a react component in this package) has been moved to its own package, and can now be imported from the UI without having to import from the server-side only package @kbn/config-schema.

For maintainers

@afharo afharo requested review from a team as code owners August 30, 2024 13:48
@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Search labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo enabled auto-merge (squash) August 30, 2024 13:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/byte-size-value - 27 +27

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/config-schema 20 19 -1
Unknown metric groups

API count

id before after diff
@kbn/byte-size-value - 27 +27

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as draft December 12, 2024 23:05
auto-merge was automatically disabled December 12, 2024 23:05

Pull request was converted to draft

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Search technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants