Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move @kbn/config-schema to server] kbn-telemetry-tools #191686

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 28, 2024
@afharo afharo requested a review from a team as a code owner August 28, 2024 23:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:33
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / Use get case configuration hook returns the initial configuration if none exists

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/telemetry-tools 14 13 -1

Total ESLint disabled count

id before after diff
@kbn/telemetry-tools 14 13 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit f22bc8d into elastic:main Aug 29, 2024
21 checks passed
@afharo afharo deleted the move-config-schema-to-server/kbn-telemetry-tools branch August 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants