Km/flatpak devel #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew translation interface (bitwarden#11572)
* update conditional to only exit early if value is null - The UriMatchStrategy for Domain was 0 and hitting the conditional * add baseDomain test
* add raw data component * fix tests * simplify logic. fix tests * revert change to default config service * remove cipher report dep. fix tests. * revert changes to mock data and specs * remove mock data * use orgId param * fix test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…bitwarden#11440) * Refactor personal-ownership.component to use reactive form * Refactor personal-ownership policy component to use base component form control
…u when identities are turned off (bitwarden#11592)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: SmithThe4th <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: SmithThe4th <[email protected]>
* PM-8112 - Update classes of existing registration icons * PM-8112 - Add new icons * PM-8112 - Export icons from libs/auth * PM-8112 - RegistrationStart - Add new user icon as page icon * PM-8112 - Replace RegistrationCheckEmailIcon with new icon so it displays properly * PM-8112 - RegistrationFinish - Add new icon across clients * PM-8112 - Registration start comp - update page icon and page title on state change to match figma * PM-8112 - RegistrationFinish - adding most of framework for changing page title & subtitle when an org invite is in state. * PM-8112 - Add joinOrganizationName to all clients translations * PM-8112 - RegistrationFinish - Remove default page title & subtitle and let onInit logic figure out what to set based on flows. * PM-8112 - RegistrationStart - Fix setAnonLayoutWrapperData calls * PM-8112 - RegistrationFinish - simplify qParams init logic to make handling loading and page title and subtitle setting easier. * PM-8112 - Registration Link expired - move icon to page icon out of main content * PM-8112 - RegistrationFinish - Refactor init logic further into distinct flows. * PM-8112 - Fix icons * PM-8112 - Extension AppRoutingModule - move sign up start & finish routes under extension anon layout * PM-8112 - Fix storybook * PM-8112 - Clean up unused prop * PM-8112 - RegistrationLockAltIcon tweaks * PM-8112 - Update icons to have proper styling * PM-8112 - RegistrationUserAddIcon - remove unnecessary svg class * PM-8112 - Fix icons
* BRE-101: Remove dept-devops from CODEOWNERS * Fix * Update codeowners
…e business rules (bitwarden#11223) * Declare feature flag * Introduce new model properties * Reference feature toggle in template * Fix bugs caught during manual testing
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <[email protected]>
* Enforce 5000 iteration minimum for prelogin * Fix tests * Add more extensive tests * Add loginstrategy prelogin downgrade test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add Icon documentation * Add 7th bullet * Icon docs - add context on how to go from hex values to appropriate tailwind classes. * 7th bullet needs bold to look right * Add color icon per suggestion
…heir vault (bitwarden#11411) * Update AccountService to include a method for setting the managedByOrganizationId * Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization * Add missing method to FakeAccountService * Remove the setAccountManagedByOrganizationId method from the AccountService abstract class. * Refactor AccountComponent to use OrganizationService to check for managing organization * Rename managesActiveUser to userIsManagedByOrganization * Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models * Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property
Co-authored-by: bitwarden-devops-bot <[email protected]>
Co-authored-by: bitwarden-devops-bot <[email protected]>
Co-authored-by: bitwarden-devops-bot <[email protected]>
* Added new Is-Beta header * Updated beta to prerelease
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…nges and forcibly change the UI on browser & desktop to make for a seamless experience without having to refresh. (bitwarden#11830)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…en#11853) * rename acess intelligence to risk insights * keep branch name * replace all instances of AccessIntelligence. strip raw data + members to just the table * revert change to feature flag name
…#11436) * remove the time threshold flag * Remove the time threshold flag
bitwarden#11816) * rough-in passphrase validation failure handling * trigger valid change from settings * fix `max` constraint enforcement * add taps for generator validation monitoring/debugging * HTML constraints validation rises like a phoenix * remove min/max boundaries to fix chrome display issue * bind settings components as view children of options components * remove defunct `okSettings$` * extend validationless generator to passwords * extend validationless generator to catchall emails * extend validationless generator to forwarder emails * extend validationless generator to subaddress emails * extend validationless generator to usernames * fix observable cycle * disable generate button when no algorithm is selected * prevent duplicate algorithm emissions * add constraints that assign email address defaults
… any accounts (bitwarden#11827) * Add hasLoggedInAccount to check if there is a logged in account * Update Storybook providers * Revert "Update Storybook providers" This reverts commit 646506a. * Reapply "Update Storybook providers" This reverts commit d86744a. * Add story for HasLoggedInAccountExample * Remove unused imports
… dropdown (bitwarden#11866) * Add bit-menu-panel class and bitmenuitem attribute * Add data-testids instead of class/attributes
* fix safari extension opening * Update apps/browser/src/platform/browser/browser-api.ts Co-authored-by: Justin Baur <[email protected]> * remove whitespace * remove check for id --------- Co-authored-by: Justin Baur <[email protected]>
…twarden#11790) * Trigger self hosted settings dialog on select close * Simplify triggering self hosted env config dialog * Always emit selected value * Update variable naming of lastSelectedValue to userSelectedValue to better reflect purpose * Add comment for userSelectedValue variable * Remove userSelectedValue and simply emit a closed event * Remove passing selectedRegion in closed event
…itwarden#11884) - Allows autofill to fill both email and password
…gistration disabled (bitwarden#11811) * Add server settings model and service. * Inject ServerSettingsService into the login-secondary-content component. * Fix merge conflict * Add server settings to old views * Remove server settings from desktop/mobile * Cleanup unused code * Remove changes to default config * Conditionally show/hide HR element * Add tests * PM-5237 - Move ServerSettingsService to jslib-services.module so it is the same across all clients and to solve NullInjectorErrors on desktop & browser extension * Remove change to v1 components * Rename ServerSettingsService to DefaultServerSettingsService * Remove unnecessary map call * Remove server interface in favor of using ServerSettings class * Add back HR element --------- Co-authored-by: Jared Snider <[email protected]>
* Remove unused regex * Remove viewChild reference from markup --------- Co-authored-by: Daniel James Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes