Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/PM-13318 - Update remaining page titles to new translation interface #11572

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Oct 15, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13318
Initial PR: #11513

📔 Objective

To update a few missed page titles & subtitles to the proper new structure to ensure they are translated.

📸 Screenshots

Hint Before:
image

Hint after:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden changed the title PM-13318 - Fix missed page titles which didn't get converted to the n… Auth/PM-13318 - Update remaining page titles to new translation interface Oct 15, 2024
@JaredSnider-Bitwarden JaredSnider-Bitwarden marked this pull request as ready for review October 15, 2024 21:08
@JaredSnider-Bitwarden JaredSnider-Bitwarden requested a review from a team as a code owner October 15, 2024 21:08
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.16%. Comparing base (70d83fe) to head (fcfcdf7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11572   +/-   ##
=======================================
  Coverage   33.16%   33.16%           
=======================================
  Files        2779     2779           
  Lines       86310    86310           
  Branches    16445    16445           
=======================================
  Hits        28621    28621           
  Misses      55415    55415           
  Partials     2274     2274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsea60eb3a-2678-47a5-9669-5492c10b1759

No New Or Fixed Issues Found

@JaredSnider-Bitwarden JaredSnider-Bitwarden merged commit 34e2d3d into main Oct 16, 2024
43 of 44 checks passed
@JaredSnider-Bitwarden JaredSnider-Bitwarden deleted the auth/pm-13318/fix-defects branch October 16, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants