Auth/PM-13318 - AnonLayoutWrapperData Refactor to add full Translation support #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing scenarios (untranslated string, translated string, and translated string with placeholders)
|
New Issues
Fixed Issues
|
justindbaur
previously approved these changes
Oct 11, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11513 +/- ##
==========================================
- Coverage 33.17% 33.17% -0.01%
==========================================
Files 2779 2779
Lines 86223 86225 +2
Branches 16420 16420
==========================================
Hits 28604 28604
- Misses 55353 55355 +2
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
rr-bw
approved these changes
Oct 11, 2024
Comment on lines
+240
to
+242
| pageSubtitle: { | ||
| key: "checkYourEmail", | ||
| }, |
There was a problem hiding this comment.
Non-blocking nit: You could keep the non-translated version here, as you did in the AnonLayoutWrapper stories.
JaredSnider-Bitwarden
deleted the
auth/pm-13318/anon-layout-translation-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13318
📔 Objective
To refactor the
AnonLayoutWrapperDatainterface to support all possible string scenarios (untranslated string, translated string, and translated string with placeholders).⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes