-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11404] Account Management: Prevent a verified user from purging their vault #11411
[PM-11404] Account Management: Prevent a verified user from purging their vault #11411
Conversation
…ased on a feature flag and if the user is managed by an organization
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11411 +/- ##
==========================================
- Coverage 33.20% 33.20% -0.01%
==========================================
Files 2782 2782
Lines 86474 86484 +10
Branches 16481 16484 +3
==========================================
- Hits 28715 28714 -1
- Misses 55474 55483 +9
- Partials 2285 2287 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving platform owned code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our call, I am requesting that we do the following:
- Move
managedByOrganizationId
out of theAccountService
and into its own OrgUser domain service (name is up to you) with a reactive interface as we want to keep the baseAccountInfo
type applicable to all users. - Rename
managedByOrganizationId
to a more clear name to match the server naming refactor we discussed.
…ervice abstract class.
…aging organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Appreciate the docs on managesActiveUser
as well!
…rganization data and response models
…gedByOrganization property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Platform owns any files in this PR anymore? You should be able to merge without my approval if you make any additional changes
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11404
📔 Objective
If the Account Deprovisioning feature flag is enabled and the user is managed by an organization then hide the
Purge vault
button.Server PR: bitwarden/server#4853
📸 Screenshots
Feature flag enabled and account managed:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes