-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13736] - Safari - fix send options viewsLeft #11594
Conversation
New Issues
Fixed Issues
|
CheckboxModule, | ||
CommonModule, | ||
FormFieldModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetized the imports.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11594 +/- ##
=======================================
Coverage 33.18% 33.19%
=======================================
Files 2782 2782
Lines 86439 86440 +1
Branches 16473 16473
=======================================
+ Hits 28685 28692 +7
+ Misses 55469 55463 -6
Partials 2285 2285 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 This also affects validation on the generator screen. I'm glad you tracked down the root cause!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13736
📔 Objective
This PR fixes a bug where in Safari the
n Views Left
translation was not insertingn
into the message. This appears to be due to the fact that Safari doesn't handle interpolating numbers into strings within the translation service.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes