Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13736] - Safari - fix send options viewsLeft #11594

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[PM-13736] - Safari - fix send options viewsLeft #11594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e13c7f
fix send options viewsLeft
jaasen-livefront Oct 16, 2024
4dd0d7e
Merge branch 'main' into PM-13736
jaasen-livefront Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
templateUrl: "./send-options.component.html",
standalone: true,
imports: [
SectionComponent,
SectionHeaderComponent,
TypographyModule,
JslibModule,
CardComponent,
FormFieldModule,
ReactiveFormsModule,
IconButtonModule,
CheckboxModule,
CommonModule,
FormFieldModule,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized the imports.

IconButtonModule,
JslibModule,
ReactiveFormsModule,
SectionComponent,
SectionHeaderComponent,
TypographyModule,
],
})
export class SendOptionsComponent implements OnInit {
Expand All @@ -61,10 +61,12 @@
return this.config.mode === "edit" && this.sendOptionsForm.value.maxAccessCount !== null;
}

get viewsLeft(): number {
return this.sendOptionsForm.value.maxAccessCount
? this.sendOptionsForm.value.maxAccessCount - this.sendOptionsForm.value.accessCount
: 0;
get viewsLeft() {
return String(

Check warning on line 65 in libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts

View check run for this annotation

Codecov / codecov/patch

libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts#L65 

Added line #L65 was not covered by tests
this.sendOptionsForm.value.maxAccessCount
? this.sendOptionsForm.value.maxAccessCount - this.sendOptionsForm.value.accessCount
: 0,
);
}

constructor(
Expand Down
Loading