-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14369] Hide account switcher if on login page and not logged into any accounts #11827
[PM-14369] Hide account switcher if on login page and not logged into any accounts #11827
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11827 +/- ##
==========================================
- Coverage 33.63% 33.62% -0.02%
==========================================
Files 2821 2821
Lines 88115 88124 +9
Branches 16784 16786 +2
==========================================
- Hits 29635 29628 -7
- Misses 56160 56176 +16
Partials 2320 2320 ☔ View full report in Codecov by Sentry. |
…gin-page-and-not-logged-in
…gin-page-and-not-logged-in
…gin-page-and-not-logged-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great, but we need to update the apps/browser/src/auth/popup/extension-anon-layout-wrapper/extension-anon-layout-wrapper.stories.ts
as storybook is failing with an error: ERROR NullInjectorError: R3InjectorError(Standalone[ExtensionAnonLayoutWrapperComponent])[AccountSwitcherService -> AccountSwitcherService -> AccountSwitcherService -> AccountService -> AccountService]:
due to the addition of the new service dependency.
…gin-page-and-not-logged-in
…gin-page-and-not-logged-in
This reverts commit 646506a.
…d-not-logged-in' of https://github.com/bitwarden/clients into auth/pm-14369/hide-account-switcher-if-on-login-page-and-not-logged-in
This reverts commit d86744a.
…gin-page-and-not-logged-in
…gin-page-and-not-logged-in
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14369?atlOrigin=eyJpIjoiNDEwN2RkODhjYWQ2NGFmY2JhYTNhOTA4NDEzNDdkODEiLCJwIjoiaiJ9
📔 Objective
The
availableAccounts$
looks to have a defaultaddAccount
accounts, so it is not empty. The*ngIf
is then truthy and the account switcher component is always shown. I've added ahasLoggedInAccount
variable and added that to the check.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes