Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11613] Refactor personal-ownership.component to use reactive form #11440

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Oct 7, 2024

🎟️ Tracking

PM-11613

📔 Objective

This PR refactors the personal-ownership.component to use a reactive form.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner October 7, 2024 15:19
@BTreston BTreston requested a review from addisonbeck October 7, 2024 15:19
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Details6efc78a9-b1ac-45e1-a253-22b546d38f1c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 909 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 833 Attack Vector
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 379 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 420 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 839
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 900
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 408
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 367

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.18%. Comparing base (68f4c2e) to head (4f57afb).
Report is 81 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11440      +/-   ##
==========================================
- Coverage   33.22%   33.18%   -0.04%     
==========================================
  Files        2740     2772      +32     
  Lines       85790    86072     +282     
  Branches    16365    16396      +31     
==========================================
+ Hits        28506    28567      +61     
- Misses      55023    55239     +216     
- Partials     2261     2266       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BTreston BTreston changed the title Refactor personal-ownership.component to use reactive form [PM-11920] Refactor personal-ownership.component to use reactive form Oct 9, 2024
@BTreston BTreston changed the title [PM-11920] Refactor personal-ownership.component to use reactive form [PM-11613] Refactor personal-ownership.component to use reactive form Oct 9, 2024
@BTreston BTreston requested a review from jrmccannon October 14, 2024 19:25
@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud October 16, 2024 17:52 Inactive
@BTreston BTreston merged commit a72f3a2 into main Oct 16, 2024
39 checks passed
@BTreston BTreston deleted the ac/pm-11613-Migrate-personal-ownership-component branch October 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants