-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11613] Refactor personal-ownership.component to use reactive form #11440
Merged
BTreston
merged 2 commits into
main
from
ac/pm-11613-Migrate-personal-ownership-component
Oct 16, 2024
Merged
[PM-11613] Refactor personal-ownership.component to use reactive form #11440
BTreston
merged 2 commits into
main
from
ac/pm-11613-Migrate-personal-ownership-component
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11440 +/- ##
==========================================
- Coverage 33.22% 33.18% -0.04%
==========================================
Files 2740 2772 +32
Lines 85790 86072 +282
Branches 16365 16396 +31
==========================================
+ Hits 28506 28567 +61
- Misses 55023 55239 +216
- Partials 2261 2266 +5 ☔ View full report in Codecov by Sentry. |
jrmccannon
requested changes
Oct 8, 2024
apps/web/src/app/admin-console/organizations/policies/personal-ownership.component.html
Outdated
Show resolved
Hide resolved
apps/web/src/app/admin-console/organizations/policies/personal-ownership.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/admin-console/organizations/policies/personal-ownership.component.html
Outdated
Show resolved
Hide resolved
BTreston
changed the title
Refactor personal-ownership.component to use reactive form
[PM-11920] Refactor personal-ownership.component to use reactive form
Oct 9, 2024
BTreston
changed the title
[PM-11920] Refactor personal-ownership.component to use reactive form
[PM-11613] Refactor personal-ownership.component to use reactive form
Oct 9, 2024
jrmccannon
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11613
📔 Objective
This PR refactors the personal-ownership.component to use a reactive form.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes