-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11778] Removed super syntax and replaced with this #11511
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11511 +/- ##
==========================================
- Coverage 33.17% 33.17% -0.01%
==========================================
Files 2772 2779 +7
Lines 86098 86223 +125
Branches 16400 16420 +20
==========================================
+ Hits 28566 28604 +38
- Misses 55266 55353 +87
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11778
📔 Objective
Addressing misuse of
super
by replacing withthis
, so that we can update to TypeScript 5.3.TypeScript 5.3 introduces checks for super misuse on instance properties. Documentation about the change: Documentation - TypeScript 5.3
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes