Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11778] Removed super syntax and replaced with this #11511

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Oct 11, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11778

📔 Objective

Addressing misuse of super by replacing with this, so that we can update to TypeScript 5.3.

TypeScript 5.3 introduces checks for super misuse on instance properties. Documentation about the change: Documentation - TypeScript 5.3

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 marked this pull request as ready for review October 11, 2024 16:15
@trmartin4 trmartin4 requested a review from a team as a code owner October 11, 2024 16:15
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 33.17%. Comparing base (49b26db) to head (6081609).
Report is 58 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/browser/src/auth/popup/two-factor.component.ts 0.00% 6 Missing ⚠️
apps/browser/src/auth/popup/sso.component.ts 0.00% 3 Missing ⚠️
apps/browser/src/auth/popup/login.component.ts 0.00% 2 Missing ⚠️
...rowser/src/auth/popup/two-factor-auth.component.ts 0.00% 2 Missing ⚠️
apps/desktop/src/auth/sso.component.ts 0.00% 2 Missing ⚠️
apps/desktop/src/auth/two-factor.component.ts 0.00% 2 Missing ⚠️
apps/browser/src/auth/popup/hint.component.ts 0.00% 1 Missing ⚠️
apps/browser/src/auth/popup/lock.component.ts 0.00% 1 Missing ⚠️
...src/auth/popup/login-via-auth-request.component.ts 0.00% 1 Missing ⚠️
...src/auth/login/login-via-auth-request.component.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11511      +/-   ##
==========================================
- Coverage   33.17%   33.17%   -0.01%     
==========================================
  Files        2772     2779       +7     
  Lines       86098    86223     +125     
  Branches    16400    16420      +20     
==========================================
+ Hits        28566    28604      +38     
- Misses      55266    55353      +87     
  Partials     2266     2266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsaf025235-2ab5-4327-b64b-87ae06d80c91

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 59
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 515
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 342
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 891
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 191
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 668
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 196
MEDIUM Unpinned Actions Full Length Commit SHA /release-browser.yml: 96
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 359
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 181
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 191
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 71
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 247
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 21
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 180
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 507
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 94
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 141
MEDIUM Unpinned Actions Full Length Commit SHA /publish-web.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /release-browser.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 405
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 222
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 48
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 51
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 367
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 194
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 499
MEDIUM Unpinned Actions Full Length Commit SHA /brew-bump-desktop.yml: 26
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 187
MEDIUM Unpinned Actions Full Length Commit SHA /staged-rollout-desktop.yml: 29
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 408
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 270
MEDIUM Unpinned Actions Full Length Commit SHA /release-web.yml: 57
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1293
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 162
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 297
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 248
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1339
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 41
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 82
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 104
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 297
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 201
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 267
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 523
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 122
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 245
MEDIUM Unpinned Actions Full Length Commit SHA /release-web.yml: 41
MEDIUM Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 23
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 35

@trmartin4 trmartin4 merged commit 0f525fa into main Oct 16, 2024
58 checks passed
@trmartin4 trmartin4 deleted the auth/pm-11778/remove-super branch October 16, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants